Skip to content

[SYCL][Test] Make testsuite respect SYCL_LIB_DUMPS_ONLY #14879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 22, 2024
Merged

[SYCL][Test] Make testsuite respect SYCL_LIB_DUMPS_ONLY #14879

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1d5a436
Make testsuite respect SYCL_LIB_DUMPS_ONLY
ldrumm Jul 31, 2024
c20a242
fixup! Make testsuite respect SYCL_LIB_DUMPS_ONLY
ldrumm Aug 1, 2024
0454727
fixup! Make testsuite respect SYCL_LIB_DUMPS_ONLY
ldrumm Aug 1, 2024
564048c
fixup! Make testsuite respect SYCL_LIB_DUMPS_ONLY
ldrumm Aug 1, 2024
db859fb
Fix quoting for python black
ldrumm Aug 22, 2024
1a5a09a
Update format.py
ldrumm Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion sycl/test/format.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
import os
import re

SUFFIXES = {'.hpp'}


class SYCLHeadersTest(lit.formats.TestFormat):
def getTestsForPath(
Expand All @@ -21,7 +23,8 @@ def getTestsInDirectory(self, testSuite, path_in_suite, litConfig, localConfig):
for dirpath, _, filenames in os.walk(source_path):
relative_dirpath = dirpath[len(localConfig.sycl_include) + 1 :]
for filename in filenames:
if not filename.endswith(".hpp"):
suffix = os.path.splitext(filename)[1]
if suffix not in SUFFIXES or suffix not in litConfig.suffixes:
Copy link
Contributor

@AlexeySachkov AlexeySachkov Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ldrumm, I've just realized that this patch had completely disable the testing suite :)

We don't have .hpp registered as a suffix and therefore we always skip all those tests. This is more of a FYI, I'm working on a revamp/expansion of the suite in scope of #16012, so I will fix it as part of that effort

Copy link
Contributor

@AlexeySachkov AlexeySachkov Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed this in #16117

continue
filepath = os.path.join(dirpath, filename)

Expand Down