Skip to content

[Clang][Driver] Disable ITT annotations in device code by default #14910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 30, 2024
Merged

[Clang][Driver] Disable ITT annotations in device code by default #14910

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9bc06d1
Disable ITT annotations by default
uditagarwal97 Aug 1, 2024
8a70ffb
Fix LIT tests
uditagarwal97 Aug 1, 2024
4427bc0
Merge branch 'sycl' into udit/itt_annot
uditagarwal97 Oct 28, 2024
d3255ee
Merge remote-tracking branch 'upstream/sycl' into udit/itt_annot
uditagarwal97 Oct 28, 2024
91d1483
Disable ITT annotations under preview-breaking flag
uditagarwal97 Oct 28, 2024
400c802
Revert "Disable ITT annotations under preview-breaking flag"
uditagarwal97 Oct 28, 2024
846607f
Fix driver LIT test failures
uditagarwal97 Oct 29, 2024
4149164
Fix typo
uditagarwal97 Oct 29, 2024
65a6a64
Address feedback
uditagarwal97 Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clang/lib/Driver/ToolChains/Clang.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5428,7 +5428,7 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA,
// only be used for SPIR/SPIR-V based targets.
if (Triple.isSPIROrSPIRV())
if (Args.hasFlag(options::OPT_fsycl_instrument_device_code,
options::OPT_fno_sycl_instrument_device_code, true))
options::OPT_fno_sycl_instrument_device_code, false))
CmdArgs.push_back("-fsycl-instrument-device-code");

if (!SYCLStdArg) {
Expand Down
2 changes: 1 addition & 1 deletion clang/lib/Driver/ToolChains/SYCL.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ SYCL::getDeviceLibraries(const Compilation &C, const llvm::Triple &TargetTriple,
}

if (Args.hasFlag(options::OPT_fsycl_instrument_device_code,
options::OPT_fno_sycl_instrument_device_code, true))
options::OPT_fno_sycl_instrument_device_code, false))
addLibraries(SYCLDeviceAnnotationLibs);

#if !defined(_WIN32)
Expand Down