Skip to content

[DeviceSanitizer] refine option parsing #15293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 25, 2024
Merged

[DeviceSanitizer] refine option parsing #15293

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2dd1fb0
change ur tag
yingcong-wu Aug 29, 2024
d4363db
add test
yingcong-wu Sep 5, 2024
cf4fe81
update ur
yingcong-wu Sep 5, 2024
ffad52b
remove change of UR tag
yingcong-wu Sep 24, 2024
df42f65
fix typo
yingcong-wu Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...Sanitizer/common/config-red-zone-size.cpp → ...sSanitizer/common/option-redzone-size.cpp
View file
Open in desktop
File renamed without changes.
39 changes: 39 additions & 0 deletions sycl/test-e2e/AddressSanitizer/common/options-invalid.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
// REQUIRES: linux
Copy link
Contributor

@AlexeySachkov AlexeySachkov Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an incorrect location for this test. Functionality that is being tested resides in Unified Runtime and therefore it should be tested there

// RUN: %{build} %device_asan_flags -O0 -g -o %t
// RUN: %{run} %t

// Invalid ur option format
// RUN: env UR_LAYER_ASAN_OPTIONS=a:1,b:1 %{run} not %t 2>&1 | FileCheck %s --check-prefixes INVLAID-FORMAT
// INVLAID-FORMAT: <SANITIZER>[ERROR]: Wrong format of the UR_LAYER_ASAN_OPTIONS environment variable value

// Invalid bool option
// RUN: env UR_LAYER_ASAN_OPTIONS=debug:yes %{run} not %t 2>&1 | FileCheck %s --check-prefixes INVLAID-BOOL
// INVLAID-BOOL: <SANITIZER>[ERROR]: "debug" is set to "yes", which is not an valid setting. Acceptable input are: for enable, use: "1" "true"; for disable, use: "0" "false".

// Invalid quarantine_size_mb
// RUN: env UR_LAYER_ASAN_OPTIONS=quarantine_size_mb:-1 %{run} not %t 2>&1 | FileCheck %s --check-prefixes INVLAID-QUARANTINE
// RUN: env UR_LAYER_ASAN_OPTIONS=quarantine_size_mb:4294967296 %{run} not %t 2>&1 | FileCheck %s --check-prefixes INVLAID-QUARANTINE
// INVLAID-QUARANTINE: <SANITIZER>[ERROR]: "quarantine_size_mb" should be an integer in range[0, 4294967295].

// Invalid redzone and max_redzone
// RUN: env UR_LAYER_ASAN_OPTIONS=redzone:abc %{run} not %t 2>&1 | FileCheck %s --check-prefixes INVLAID-REDZONE
// INVLAID-REDZONE: <SANITIZER>[ERROR]: "redzone" should be an integer in range[0, 16].
// RUN: env UR_LAYER_ASAN_OPTIONS=max_redzone:abc %{run} not %t 2>&1 | FileCheck %s --check-prefixes INVLAID-MAXREDZONE
// INVLAID-MAXREDZONE: <SANITIZER>[ERROR]: "max_redzone" should be an integer in range[0, 2048].



#include <sycl/usm.hpp>

int main() {
sycl::queue q;
constexpr std::size_t N = 8;
auto *array = sycl::malloc_device<char>(N, q);

q.submit([&](sycl::handler &h) {
h.single_task<class Test>([=]() { ++array[0]; });
}).wait();

sycl::free(array, q);
return 0;
}
Loading