-
Notifications
You must be signed in to change notification settings - Fork 796
[UR][L0] Refactor to remove default constructor inits #15309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5fd0d3f to
82dc0ad
Compare
82dc0ad to
a2cca10
Compare
-pre-commit PR for oneapi-src/unified-runtime#2063 Signed-off-by: Neil R. Spruit <[email protected]>
a2cca10 to
561226d
Compare
|
looks like the nvidia runner is in a bad state: this tag update only affects the level zero adapter so we should be ok to merge without that job |
|
@intel/llvm-gatekeepers please merge if you're ok doing so without the cuda build (given the above) |
|
sorry i just fixed the runner, ill restart the job and merge once it passes, sorry for the trouble |
|
@nrspruit - This PR is causing problems on local builds, for example UR trace: @kbenzie | @aarongreig - Is it safe to revert this while this gets investigated? (#15753) |
This reverts commit e19e557.
I've approved the revert @steffenlarsen, I'll need to do the same in UR until a fix is found. |
This patch weas authored a while back now, it is possible the code changed enough causing an issue, I will rebase and update the change to verify no issues before re-posting thank you! |
-pre-commit PR for oneapi-src/unified-runtime#2063