[DeviceSanitizer] Only allows to report one error per each kernel launch #15326
+36
−175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When error is detected, the corresponding work-item will exit without unpoisoning local/private shadow memory. Then other work-items are eary to cause false alarms. So, we only allows to report one error per each kernel launch by default.
zhaomaosu
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
How about skipping sanitizer when "UR_SANITIZER_INCLUDE_DIR" is empty string? |
Done. |
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
yingcong-wu
approved these changes
Oct 22, 2024
|
please rebase (and ping me, I want to merge this asap) |
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
@pbalcer, thanks, done. |
yingcong-wu
approved these changes
Oct 28, 2024
|
@intel/llvm-reviewers-runtime can you please review? thanks. |
pbalcer
reviewed
Oct 28, 2024
pbalcer
approved these changes
Oct 28, 2024
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
approved these changes
Oct 28, 2024
|
@intel/llvm-gatekeepers please merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When error is detected, the corresponding work-item will exit without unpoisoning local/private shadow memory. Then other work-items are easy to cause false alarms. So, we only allows to report one error per each kernel launch by default.
UR Part: oneapi-src/unified-runtime#2069