-
Notifications
You must be signed in to change notification settings - Fork 796
[SYCL] Enable checking the result of max_num_work_groups query with exceeded launch limits on more backends (hip and opencl) #15369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
martygrant
merged 6 commits into
intel:sycl
from
GeorgeWeb:georgi/unsupported-max-coop-wgs-ur-api
Oct 10, 2024
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b5d35b0
[SYCL] Enable checking the result of max_num_work_groups query with e…
e9ba152
Update assert message
6759b8e
Update fetch UR commit tag
1b1dc63
Merge remote-tracking branch 'upstream/sycl' into georgi/unsupported-…
dcc04da
Merge branch 'sycl' into georgi/unsupported-max-coop-wgs-ur-api
aarongreig c90cb43
Update UR tag.
aarongreig File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -117,13 +117,14 @@ if(SYCL_UR_USE_FETCH_CONTENT) | |
| endfunction() | ||
|
|
||
| set(UNIFIED_RUNTIME_REPO "https://github.com/oneapi-src/unified-runtime.git") | ||
| # commit b79ebe4e98789144bcdf3832088eb6e6b5ae6967 | ||
| # Merge: 7b4bc761 fbb6e862 | ||
| # Author: Kenneth Benzie (Benie) <[email protected]> | ||
| # Date: Fri Oct 4 16:39:59 2024 +0100 | ||
| # Merge pull request #2018 from wenju-he/L0-bindless-image-device-query | ||
| # [L0] Fix device query of bindless image support | ||
| set(UNIFIED_RUNTIME_TAG b79ebe4e98789144bcdf3832088eb6e6b5ae6967) | ||
| # commit df6da35d6e67f2383db28dd49ab08c5c0ef541d2 | ||
| # Merge: 67590533 55bd5636 | ||
| # Author: aarongreig <[email protected]> | ||
| # Date: Mon Oct 7 12:28:07 2024 +0100 | ||
| # Merge pull request #2038 from GeorgeWeb/georgi/unsupported-max-coop-wgsize | ||
| # [UR][hip][opencl] Mark urKernelSuggestMaxCooperativeGroupCountExp as unsupported | ||
| # instead of returning misleading default value | ||
| set(UNIFIED_RUNTIME_TAG df6da35d6e67f2383db28dd49ab08c5c0ef541d2) | ||
|
|
||
| set(UMF_BUILD_EXAMPLES OFF CACHE INTERNAL "EXAMPLES") | ||
| # Due to the use of dependentloadflag and no installer for UMF and hwloc we need | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a small thing, but can we improve the assert message? It seems that the message we want some other developer in the future to understand is that the query SHOULD have failed (but didn't).