[SYCL] Add testing for arrays as free function kernel parameters #15411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fznamznon
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Fznamznon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Fznamznon
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Fznamznon
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Fznamznon
force-pushed
the
free-functions-array-params
branch
from
32f1db8 to
d97bde0
Compare
Fznamznon
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Fznamznon
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Fznamznon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Fznamznon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Fznamznon
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Fznamznon
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Fznamznon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
bso-intel
approved these changes
Sep 27, 2024
|
@intel/dpcpp-cfe-reviewers , could you please take a look? |
elizabethandrews
approved these changes
Oct 2, 2024
smanna12
approved these changes
Oct 3, 2024
|
@intel/llvm-gatekeepers , could you please merge? This is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arrays cannot be passed by value as function parameters, so they won’t be supported as free function parameters. To pass an array the simplest way is to wrap it in a struct and pass the struct. This PR adds tests for the case