[SYCL][Driver] Update support for HIP/AMDGCN targets in DeviceConfigFile #15414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds new supported targets, gfx941 and gfx942. It also fixes the supported subgroup size config value for AMD RDNA GPUs, due to the fact that the ROCm driver does not allow support for wave64 mode in HIP, for gfx10 and gx11 family of GPUs, which are based on the RDNA architecture. This is a result of wavefront/cross-lane functions that only work with wave32.
GeorgeWeb
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
GeorgeWeb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
GeorgeWeb
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
GeorgeWeb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Clang :: Driver/sycl.c Failing clang test on Windows looks unrelated to this. Update: Passing after rebase on latest. |
…e-config-file-amd
GeorgeWeb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
GeorgeWeb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mdtoguchi
approved these changes
Sep 23, 2024
|
@intel/dpcpp-tools-reviewers This is not a high prio change by all means, so no rush. I am just pinging for reminder in case it may have been missed by any chance. Thanks! |
AlexeySachkov
approved these changes
Oct 8, 2024
|
@intel/llvm-gatekeepers This looks ready to merge now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds new supported targets, gfx941 and gfx942. It also fixes the supported subgroup size config value for AMD RDNA GPUs, due to the fact that the ROCm driver does not allow support for wave64 mode in HIP, for gfx10 and gx11 family of GPUs, which are based on the RDNA architecture. This is a result of wavefront/cross-lane functions that only work with wave32.