[SYCL][Joint Matrix][E2E] Add Joint Matrix tests for matrix dimension as function argument and runtime input

[YixingZhang007]

Description:

1. The test joint_matrix_bf16_fill_k_cache_arg_dim.cpp has been added in sycl/test-e2e/Matrix to validate passing matrix dimensions as function arguments, instead of templated parameters, to the joint_matmul function.
2. The test joint_matrix_bf16_fill_k_cache_runtime_dim.cpp has been added in sycl/test-e2e/Matrix to validate that the program works for reading matrix dimensions at runtime instead of compile time.
3. The joint_matrix_bf16_fill_k_cache_impl.hpp file has been modified to support the new tests.

[dkhaldi]

Added comments

[dkhaldi]

What about the runtime arguments test? I think we need that one as well.

[YixingZhang007]

What about the runtime arguments test? I think we need that one as well.

Thanks for all the suggestions for this PR 👍

I am still working on this one. I’m trying to do it in a similar way as we have for joint_matrix_bf16_cache_arg_dim.cpp, where we reuse the code in joint_matrix_bf16_cache_impl.hpp. However, I found that there will be a lot of modifications needed in joint_matrix_bf16_cache_impl.hpp because we need to change the interface for the test() function. So, I’m not sure if I should create a separate *_impl.hpp for the joint_matrix_bf16_cache_runtime_dim test.

[dkhaldi]

I am still working on this one. I’m trying to do it in a similar way as we have for joint_matrix_bf16_cache_arg_dim.cpp, where we reuse the code in joint_matrix_bf16_cache_impl.hpp. However, I found that there will be a lot of modifications needed in joint_matrix_bf16_cache_impl.hpp because we need to change the interface for the test() function. So, I’m not sure if I should create a separate *_impl.hpp for the joint_matrix_bf16_cache_runtime_dim test.

You may create a new joint_matrix_bf16_cache_runtime_dim_impl.hpp file that only contains the new test() function but uses same joint_matmul function from joint_matrix_bf16_cache_impl.hpp.

[YixingZhang007]

I am still working on this one. I’m trying to do it in a similar way as we have for joint_matrix_bf16_cache_arg_dim.cpp, where we reuse the code in joint_matrix_bf16_cache_impl.hpp. However, I found that there will be a lot of modifications needed in joint_matrix_bf16_cache_impl.hpp because we need to change the interface for the test() function. So, I’m not sure if I should create a separate *_impl.hpp for the joint_matrix_bf16_cache_runtime_dim test.

You may create a new joint_matrix_bf16_cache_runtime_dim_impl.hpp file that only contains the new test() function but uses same joint_matmul function from joint_matrix_bf16_cache_impl.hpp.

Thanks for the suggestion! I have created a new joint_matrix_bf16_cache_runtime_dim_impl.hpp.

[dkhaldi]

LGTM

[YuriPlyakhin]

LGTM

[aelovikov-intel]

@YixingZhang007 YixingZhang007 requested a review from aelovikov-intel 3 hours ago

I'm just back from vacation and this PR

1. is specific to Matrix feature/tests
2. has had lots of review comments throughout its history

@YixingZhang007 , can you please summarize what you expect from me specifically?

[YixingZhang007]

@YixingZhang007 YixingZhang007 requested a review from aelovikov-intel 3 hours ago

I'm just back from vacation and this PR

1. is specific to Matrix feature/tests
2. has had lots of review comments throughout its history

@YixingZhang007 , can you please summarize what you expect from me specifically?

Hello Andrey, sorry for the confusion! I was trying to get assistance for merging the PR from @intel/llvm-gatekeepers, because I noticed I'm not authorized to merge the PR.