[SYCL][E2E] Disable and fix address sanitizer tests for DG2 #15450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit disables the AddressSanitizer/invalid-argument/out-of-bounds.cpp and sycl/test-e2e/AddressSanitizer/invalid-argument/released-pointer.cpp tests for DG2, following the enabling of address sanitizer tests for DG2 in intel#14891. Additionally, it fixes the compilation failure in sycl/test-e2e/AddressSanitizer/nullpointer/global_nullptr.cpp which should hopefully allow it to pass as expected. Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
yingcong-wu
approved these changes
Sep 20, 2024
|
Thanks for the patch! |
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
added a commit
to steffenlarsen/llvm
that referenced
this pull request
Sep 20, 2024
…n DG2 The sycl/test-e2e/AddressSanitizer/nullpointer/global_nullptr.cpp test had compilation errors whe first enabled on DG2. The compilation error was fixed in intel#15450, but the test fails during execution on DG2. This commit disables the test for DG2. See intel#15453. Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
added a commit
that referenced
this pull request
Sep 20, 2024
…n DG2 (#15454) The sycl/test-e2e/AddressSanitizer/nullpointer/global_nullptr.cpp test had compilation errors whe first enabled on DG2. The compilation error was fixed in #15450, but the test fails during execution on DG2. This commit disables the test for DG2. See #15453. Signed-off-by: Larsen, Steffen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit disables the AddressSanitizer/invalid-argument/out-of-bounds.cpp and sycl/test-e2e/AddressSanitizer/invalid-argument/released-pointer.cpp tests for DG2, following the enabling of address sanitizer tests for DG2 in #14891.
Additionally, it fixes the compilation failure in
sycl/test-e2e/AddressSanitizer/nullpointer/global_nullptr.cpp which should hopefully allow it to pass as expected.