Skip to content

[SYCL]Remove deprecated device traits #15462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: sycl
Choose a base branch
from
Open

[SYCL]Remove deprecated device traits #15462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
69e4d63
remove deprecated device traits
abhilash1910 Sep 20, 2024
e4a9a5b
Merge branch 'sycl' into device_deprecated
abhilash1910 Sep 23, 2024
faea6e7
add review comments
abhilash1910 Oct 3, 2024
ea35a15
revert apis
abhilash1910 Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions sycl/doc/extensions/supported/sycl_ext_intel_device_info.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,19 +504,3 @@ Then the memory bus width can be obtained using the standard get\_info() interfa
if (dev.has(aspect::ext_intel_memory_bus_width)) {
auto MemoryBusWidth = dev.get_info<ext::intel::info::device::memory_bus_width>();
}

# Deprecated queries #

The table below lists deprecated, that would soon be removed and their replacements:

|Deprecated Descriptors | Replacement Descriptors |
| ------------------------------- |--------------------------- |
| info\:\:device\:\:ext\_intel\_device\_info\_uuid | ext\:\:intel\:\:info\:\:device\:\:uuid |
| info\:\:device\:\:ext\_intel\_pci\_address | ext\:\:intel\:\:info\:\:device\:\:pci\_address |
| info\:\:device\:\:ext\_intel\_gpu\_eu\_simd\_width | ext\:\:intel\:\:info\:\:device\:\:gpu\_eu\_simd\_width |
| info\:\:device\:\:ext\_intel\_gpu\__eu\_count | ext\:\:intel\:\:info\:\:device\:\:gpu\__eu\_count |
| info\:\:device\:\:ext\_intel\_gpu\_slices | ext\:\:intel\:\:info\:\:device\:\:gpu\_slices |
| info\:\:device\:\:ext\_intel\_gpu\_subslices\_per\_slice | ext\:\:intel\:\:info\:\:device\:\:gpu\_subslices\_per\_slice |
|info\:\:device\:\:ext\_intel\_gpu\_eu\_count\_per\_subslice | ext\:\:intel\:\:info\:\:device\:\:gpu\_eu\_count\_per\_subslice |
| info\:\:device\:\:ext\_intel\_gpu\_hw\_threads\_per\_eu | ext\:\:intel\:\:info\:\:device\:\:gpu\_hw\_threads\_per\_eu |
| info\:\:device\:\:ext\_intel\_max\_mem\_bandwidth | ext\:\:intel\:\:info\:\:device\:\:max\_mem\_bandwidth |
21 changes: 0 additions & 21 deletions sycl/include/sycl/info/device_traits.def
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,27 +208,6 @@ __SYCL_PARAM_TRAITS_SPEC(device, ext_oneapi_srgb, bool,
__SYCL_PARAM_TRAITS_SPEC(device, ext_intel_mem_channel, bool,
UR_DEVICE_INFO_MEM_CHANNEL_SUPPORT)

//Deprecated oneapi/intel extension
//TODO:Remove when possible
__SYCL_PARAM_TRAITS_SPEC(device, ext_intel_pci_address, std::string,
UR_DEVICE_INFO_PCI_ADDRESS)
__SYCL_PARAM_TRAITS_SPEC(device, ext_intel_gpu_eu_count, uint32_t,
UR_DEVICE_INFO_GPU_EU_COUNT)
__SYCL_PARAM_TRAITS_SPEC(device, ext_intel_gpu_eu_simd_width, uint32_t,
UR_DEVICE_INFO_GPU_EU_SIMD_WIDTH)
__SYCL_PARAM_TRAITS_SPEC(device, ext_intel_gpu_slices, uint32_t,
UR_DEVICE_INFO_GPU_EU_SLICES)
__SYCL_PARAM_TRAITS_SPEC(device, ext_intel_gpu_subslices_per_slice, uint32_t,
UR_DEVICE_INFO_GPU_SUBSLICES_PER_SLICE)
__SYCL_PARAM_TRAITS_SPEC(device, ext_intel_gpu_eu_count_per_subslice, uint32_t,
UR_DEVICE_INFO_GPU_EU_COUNT_PER_SUBSLICE)
__SYCL_PARAM_TRAITS_SPEC(device, ext_intel_gpu_hw_threads_per_eu, uint32_t,
UR_DEVICE_INFO_GPU_HW_THREADS_PER_EU)
__SYCL_PARAM_TRAITS_SPEC(device, ext_intel_device_info_uuid, detail::uuid_type,
UR_DEVICE_INFO_UUID)
__SYCL_PARAM_TRAITS_SPEC(device, ext_intel_max_mem_bandwidth, uint64_t,
UR_DEVICE_INFO_MAX_MEMORY_BANDWIDTH)

__SYCL_PARAM_TRAITS_SPEC(device, ext_oneapi_max_work_groups_1d, id<1>, __SYCL_TRAIT_HANDLED_IN_RT)
__SYCL_PARAM_TRAITS_SPEC(device, ext_oneapi_max_work_groups_2d, id<2>, __SYCL_TRAIT_HANDLED_IN_RT)
__SYCL_PARAM_TRAITS_SPEC(device, ext_oneapi_max_work_groups_3d, id<3>,
Expand Down
11 changes: 1 addition & 10 deletions sycl/include/sycl/info/device_traits_deprecated.def
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,7 @@ __SYCL_PARAM_TRAITS_DEPRECATED(preferred_interop_user_sync,"deprecated in SYCL 2
__SYCL_PARAM_TRAITS_DEPRECATED(image_max_array_size,"support for image arrays has been removed in SYCL 2020")
__SYCL_PARAM_TRAITS_DEPRECATED(opencl_c_version,"use device::get_backend_info instead")

//TODO:Remove when possible
__SYCL_PARAM_TRAITS_DEPRECATED(ext_intel_pci_address,"use ext::intel::info::device::pci_address instead")
__SYCL_PARAM_TRAITS_DEPRECATED(ext_intel_gpu_eu_count,"use ext::intel::info::device::gpu_eu_count instead")
__SYCL_PARAM_TRAITS_DEPRECATED(ext_intel_gpu_eu_simd_width,"use ext::intel::info::device::gpu_eu_simd_width instead")
__SYCL_PARAM_TRAITS_DEPRECATED(ext_intel_gpu_slices,"use ext::intel::info::device::gpu_slices instead")
__SYCL_PARAM_TRAITS_DEPRECATED(ext_intel_gpu_subslices_per_slice,"use ext::intel::info::device::gpu_subslices_per_slice instead")
__SYCL_PARAM_TRAITS_DEPRECATED(ext_intel_gpu_hw_threads_per_eu,"use ext::intel::info::device::gpu_hw_threads_per_eu instead")
__SYCL_PARAM_TRAITS_DEPRECATED(ext_intel_device_info_uuid,"use ext::intel::info::device::uuid instead")
__SYCL_PARAM_TRAITS_DEPRECATED(ext_intel_max_mem_bandwidth,"use ext::intel::info::device::max_mem_bandwidth instead")
__SYCL_PARAM_TRAITS_DEPRECATED(ext_oneapi_max_work_groups_1d,"use ext::oneapi::experimental::info::device::max_work_groups<1> instead")
__SYCL_PARAM_TRAITS_DEPRECATED(ext_oneapi_max_work_groups_2d,"use ext::oneapi::experimental::info::device::max_work_groups<2> instead")
__SYCL_PARAM_TRAITS_DEPRECATED(ext_oneapi_max_work_groups_3d,"use ext::oneapi::experimental::info::device::max_work_groups<3> instead")
__SYCL_PARAM_TRAITS_DEPRECATED(ext_oneapi_max_global_work_groups,"use ext::oneapi::experimental::info::device::max_global_work_groups instead")
__SYCL_PARAM_TRAITS_DEPRECATED(ext_oneapi_max_global_work_groups,"use ext::oneapi::experimental::info::device::max_global_work_groups instead")
Loading