Skip to content

[SYCL] Remove XFAIL directive from E2E Matrix tests #15471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[SYCL] Remove XFAIL directive from E2E Matrix tests #15471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a2faa9f
Fix device assertion bug on windows
lbushi25 Aug 29, 2024
b0683d1
Remove XFAIL from Matrix E2E tests
lbushi25 Sep 23, 2024
9fd840c
remove rogue changes
lbushi25 Sep 23, 2024
32a06fc
Merge branch 'sycl' into resolve_xfail
lbushi25 Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions sycl/test-e2e/Matrix/SG32/joint_matrix_annotated_ptr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out

// Currently row major B fails when annotated_ptr is used
// XFAIL: gpu

#include "../common.hpp"

#define SG_SZ 32
Expand Down
2 changes: 0 additions & 2 deletions sycl/test-e2e/Matrix/SG32/joint_matrix_bfloat16_colmajorA_colmajorB.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
// This tests support of col major layout for matrix B which does transpose and
// then VNNI transform. This is currently only available on AMX

// XFAIL: gpu

#include "../common.hpp"
#include <iostream>
#include <sycl/detail/core.hpp>
Expand Down
2 changes: 0 additions & 2 deletions sycl/test-e2e/Matrix/SG32/joint_matrix_bfloat16_packedB.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out

// XFAIL: gpu

#include "../common.hpp"

#define SG_SZ 32
Expand Down
1 change: 0 additions & 1 deletion sycl/test-e2e/Matrix/SG32/joint_matrix_colA_rowB_colC.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out

// XFAIL:*

#include "../common.hpp"

Expand Down
1 change: 0 additions & 1 deletion sycl/test-e2e/Matrix/SG32/joint_matrix_int8_colmajorA_colmajorB.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
// This tests support of col major layout for matrix B which does transpose and
// then VNNI transform. This is currently only available on AMX

// XFAIL: gpu

#include "../common.hpp"

Expand Down
2 changes: 0 additions & 2 deletions sycl/test-e2e/Matrix/SG32/joint_matrix_int8_rowmajorA_rowmajorB.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out

// XFAIL: gpu

#include "../common.hpp"

#define SG_SZ 32
Expand Down
2 changes: 0 additions & 2 deletions sycl/test-e2e/Matrix/SG32/joint_matrix_out_bounds.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out

// XFAIL:gpu

#include "../common.hpp"

#define SG_SZ 32
Expand Down
2 changes: 0 additions & 2 deletions sycl/test-e2e/Matrix/SG32/joint_matrix_prefetch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out

// XFAIL: gpu

// SG size = 32 is not currently supported for SYCL Joint Matrix by IGC on DG2
// UNSUPPORTED: gpu-intel-dg2

Expand Down
3 changes: 0 additions & 3 deletions sycl/test-e2e/Matrix/SG32/joint_matrix_rowmajorA_rowmajorB.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out

// Sub-group size 32 support for this test is not currently available in IGC
// XFAIL: gpu

#include "../common.hpp"

using namespace sycl;
Expand Down
2 changes: 0 additions & 2 deletions sycl/test-e2e/Matrix/SG32/joint_matrix_unaligned_k.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out

// XFAIL:gpu

#include "../common.hpp"

#define SG_SZ 32
Expand Down
1 change: 0 additions & 1 deletion sycl/test-e2e/Matrix/joint_matrix_bfloat16_colmajorA_colmajorB.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
// This tests support of col major layout for matrix B which does transpose and
// then VNNI transform. This is currently only available on AMX

// XFAIL: gpu

#include "common.hpp"

Expand Down
1 change: 0 additions & 1 deletion sycl/test-e2e/Matrix/joint_matrix_colA_rowB_colC.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out

// XFAIL:*

#include "common.hpp"

Expand Down
2 changes: 0 additions & 2 deletions sycl/test-e2e/Matrix/joint_matrix_int8_colmajorA_colmajorB.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@
// This tests support of col major layout for matrix B which does transpose and
// then VNNI transform. This is currently only available on AMX

// XFAIL: gpu

#include "common.hpp"

constexpr size_t TN = 16;
Expand Down
Loading