[SYCL] Fix std::exp(complex<double>) edge case on Windows
#15489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up for intel#15162 There are no new tests added with this PR, because we already have this edge case covered by existing tests here: https://github.com/intel/llvm/blob/3e98b3a09254863423f82d10aa7d40a8b64dbdd3/sycl/test-e2e/DeviceLib/std_complex_math_fp64_test.cpp#L202 But we don't have a Windows machine with a GPU which supports `fp64` and therefoere this edge case went unnoticed by our CI. The change was locally tested in the right environment. Patch-By: Justin Cai <[email protected]>
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
approved these changes
Sep 24, 2024
AlexeySachkov
deleted the
private/asachkov/fix-exp-complex-edge-case-fp64-win
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up for #15162
There are no new tests added with this PR, because we already have this edge case covered by existing tests here:
llvm/sycl/test-e2e/DeviceLib/std_complex_math_fp64_test.cpp
Line 202 in 3e98b3a
But we don't have a Windows machine with a GPU which supports
fp64and therefoere this edge case went unnoticed by our CI. The change was locally tested in the right environment.Patch-By: Justin Cai [email protected]