[SYCL][Graph] Reenable L0 interop test on PVC #15493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwanC
force-pushed
the
ewan/L0_native_graph_test
branch
from
da73b30 to
86217f8
Compare
EwanC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
EwanC
force-pushed
the
ewan/L0_native_graph_test
branch
from
86217f8 to
1406b30
Compare
EwanC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
EwanC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
EwanC
force-pushed
the
ewan/L0_native_graph_test
branch
from
1406b30 to
ba08697
Compare
EwanC
force-pushed
the
ewan/L0_native_graph_test
branch
from
ba08697 to
bf980a2
Compare
EwanC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
EwanC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
EwanC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
EwanC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Re-enable the interop-level-zero-launch-kernel.cpp E2E test on PVC by making the following correctness changes to the native L0 code: * Both `zeKernelSetGroupSize` and `ZeGroupCount` were set to have 1024 in the X dimensions when this is the total size of the USM allocation, and therefore the number of work items we want. Updated to use `zeKernelSuggestGroupSize` to work calculate the correct group sizes and count. * Update `zeKernelSetArgumentValue` call so that the size parameter is the size of the pointer rather than size of the USM allocation.
EwanC
force-pushed
the
ewan/L0_native_graph_test
branch
from
bf980a2 to
f85c9f7
Compare
EwanC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
EwanC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
EwanC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
fabiomestre
approved these changes
Sep 27, 2024
EwanC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
EwanC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
@intel/llvm-gatekeepers This is good to merge thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enable the interop-level-zero-launch-kernel.cpp E2E test on PVC by making the following correctness changes to the native L0 code:
zeKernelSetGroupSizeandZeGroupCountwere set to have 1024 in the X dimensions when this is the total size of the USM allocation, and therefore the number of work items we want. Updated to usezeKernelSuggestGroupSizeto work calculate the correct group sizes and count.zeKernelSetArgumentValuecall so that the size parameter is the size of the pointer rather than size of the USM allocation.