[SYCL][NFC] Optimize verifyUsedKernelBundle usage #15496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR intended to reduce amount of template instantiations performed during both host & device compilation passes, as well as reduce amount of LLVM IR emitted during host compilation pass. `handler::verifyUsedKernelBundle` is a one-line helper which was inlined to avoid one instantiation per-kernel and emission of associated LLVM IR. Its uses (now inlined) were also moved under `#ifndef __SYCL_DEVICE_ONLY__` to reduce amount of code device compiler has to parse.
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
…mize-verifykernelbundle-usage
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
…mize-verifykernelbundle-usage
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
approved these changes
Sep 26, 2024
AlexeySachkov
deleted the
private/asachkov/optimize-verifykernelbundle-usage
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intended to reduce amount of template instantiations performed during both host & device compilation passes, as well as reduce amount of LLVM IR emitted during host compilation pass.
handler::verifyUsedKernelBundleis a one-line helper which was inlined to avoid one instantiation per-kernel and emission of associated LLVM IR. Its uses (now inlined) were also moved under#ifndef __SYCL_DEVICE_ONLY__to reduce amount of code device compiler has to parse.