[SPIR-V] Reland SPV_KHR_untyped_pointers commits #15507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) This is the first part of the extension implementation. Introducing untyped pointer type. Spec: https://htmlpreview.github.io/?https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/KHR/SPV_KHR_untyped_pointers.html Original commit: KhronosGroup/SPIRV-LLVM-Translator@7dacb7cdedc9c01
This continues intel#2687 by introducing untyped variables. Spec: https://htmlpreview.github.io/?https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/KHR/SPV_KHR_untyped_pointers.html Original commit: KhronosGroup/SPIRV-LLVM-Translator@484e4070adb0a95
vmaksimo
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
vmaksimo
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
CI failures look unrelated to the change |
asudarsa
reviewed
Sep 25, 2024
| if (T->isPointerTy()) { | ||
| auto *ET = Type::getInt8Ty(T->getContext()); | ||
| auto AddrSpc = T->getPointerAddressSpace(); | ||
| auto *ET = Type::getInt8Ty(T->getContext()); |
There was a problem hiding this comment.
Change seems unnecessary. nit
|
Rerun CI |
vmaksimo
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
vmaksimo
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
bso-intel
approved these changes
Sep 28, 2024
|
@intel/llvm-gatekeepers could you please merge? Thanks! |
|
@vmaksimo this still needs an approval from @intel/dpcpp-spirv-reviewers |
VyacheslavLevytskyy
approved these changes
Oct 1, 2024
AlexeySachkov
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were reverted in pulldown PR #15464 because of the regressions.
Don't use this extension in the SYCL tests as the extension is not fully implemented yet.
Commits:
KhronosGroup/SPIRV-LLVM-Translator@7dacb7cdedc9c01
KhronosGroup/SPIRV-LLVM-Translator@484e4070adb0a95