Skip to content

Conversation

@lslusarczyk
Copy link
Contributor

Install dir can exist if old "SYCL Pre Commit on Windows / e2e" job has not finished cleanly. Removing it to be sure it does not exist also on job start.

Install dir can exist if old "SYCL Pre Commit on Windows / e2e"
job has not finished cleanly. Removing it to be sure also on job start.
@aelovikov-intel
Copy link
Contributor

I don't see how the deletion would succeed here if it failed in the previous task. When that happens, we have to manually kill zombie processes and remove files. As such, I don't see benefits, but if somebody from @intel/dpcpp-devops-reviewers sees value in this, I won't object.

@sarnex
Copy link
Contributor

sarnex commented Sep 27, 2024

Yeah I don't think this will work, on Windows you can't delete a directory if any file handles to files inside are still open.

@lslusarczyk
Copy link
Contributor Author

As CI showed this approach does not work. I don't know Windows and I don't have access to this particular machine to learn and experiment how to find zombies and kill them.

The only solution which is accessible to me is to use unique directories. This may be a temporary solution before we implement solution which @sarnex suggested in email thread (check for open files before removal, fail job if found and kill zombies as a cleanup).

@sarnex
Copy link
Contributor

sarnex commented Sep 27, 2024

I'll start working on the solution I mentioned now, hopefully it's not too hard.

@lslusarczyk
Copy link
Contributor Author

Closing as better and working solution is going to be implemented by @sarnex . Thank you for being ready to help with this!

@lslusarczyk lslusarczyk deleted the clean_dirs branch September 27, 2024 19:29
@sarnex
Copy link
Contributor

sarnex commented Sep 27, 2024

Thanks for bringing up the issue and working toward a solution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants