-
Notifications
You must be signed in to change notification settings - Fork 795
[SYCL] adding binary caching support to kernel_compiler extension #15537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] adding binary caching support to kernel_compiler extension #15537
Conversation
|
The Jenkins/Precommit failure seems to be unrelated. Several other PRs are having the RHEL Build fail and a quick test seems to suggest it is a UR dependency problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
@cperkinsintel Could you please take a look at post-commit failure on gen12 and arc: Failed Tests (1): https://github.com/intel/llvm/actions/runs/11634776354/job/32403188036 |
|
@cperkinsintel Does it seem like an easy fix? If not we might want to disable the test or revert the change. Thanks |
Trying to reuse as much of the
PersistentDeviceCodeCacheas possible. We use the same top cache directory as the regular binary caches, but with aext_kernel_compilersubdirectory and a slightly different system for assigning paths.Rather than write new tests, am just adding a "test the cache" passes to the existing tests.