Skip to content

Conversation

@cperkinsintel
Copy link
Contributor

Trying to reuse as much of the PersistentDeviceCodeCache as possible. We use the same top cache directory as the regular binary caches, but with a ext_kernel_compiler subdirectory and a slightly different system for assigning paths.

Rather than write new tests, am just adding a "test the cache" passes to the existing tests.

@cperkinsintel cperkinsintel marked this pull request as ready for review September 30, 2024 17:42
@cperkinsintel cperkinsintel requested a review from a team as a code owner September 30, 2024 17:42
@cperkinsintel
Copy link
Contributor Author

The Jenkins/Precommit failure seems to be unrelated. Several other PRs are having the RHEL Build fail and a quick test seems to suggest it is a UR dependency problem.

@cperkinsintel cperkinsintel marked this pull request as ready for review October 30, 2024 17:22
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@againull againull merged commit 5dae72c into intel:sycl Nov 1, 2024
13 checks passed
@againull
Copy link
Contributor

againull commented Nov 1, 2024

@cperkinsintel Could you please take a look at post-commit failure on gen12 and arc:


Failed Tests (1):
SYCL :: KernelCompiler/kernel_compiler_sycl.cpp

https://github.com/intel/llvm/actions/runs/11634776354/job/32403188036
https://github.com/intel/llvm/actions/runs/11634776354/job/32403188263

@sarnex
Copy link
Contributor

sarnex commented Nov 4, 2024

@cperkinsintel Does it seem like an easy fix? If not we might want to disable the test or revert the change. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants