[SYCL][HIP] Add --only-needed flag to llvm-link for AMDGCN #15558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the --only-needed flag for AMDGCN when linking against devicelib. Fixes several test cases that use kernel bundles.
MartinWehking
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
MartinWehking
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
MartinWehking
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
npmiller
changed the title
Is there a test added to verify this? |
MartinWehking
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Hi @srividya-sundaram |
MartinWehking
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
MartinWehking
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
MartinWehking
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Merging now to unbreak CI and only changes since last full CI run are in lit tests which passed on both platforms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the -only-needed flag for AMDGCN when linking against devicelib.
Fixes several test cases that use kernel bundles.