Skip to content

[Sycl][Graph] Fix command-buffer binary update implementation #15569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 30, 2024
Merged

[Sycl][Graph] Fix command-buffer binary update implementation #15569

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b4e865a
Fix command-buffer binary update implementation
fabiomestre Oct 1, 2024
b1fe8a3
Update FetchUnifiedRuntime.cmake
fabiomestre Oct 2, 2024
4470fb1
Merge branch 'sycl' into fabio/binary_update_fix
fabiomestre Oct 2, 2024
d571333
Merge branch 'sycl' into fabio/binary_update_fix
aarongreig Oct 28, 2024
cdafff4
Merge branch 'sycl' into fabio/binary_update_fix
aarongreig Oct 29, 2024
a7337c4
Merge remote-tracking branch 'github/sycl' into fabio/binary_update_fix
Oct 30, 2024
77d23fe
Restore UR commit bump
Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions sycl/cmake/modules/FetchUnifiedRuntime.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,14 +116,14 @@ if(SYCL_UR_USE_FETCH_CONTENT)
CACHE PATH "Path to external '${name}' adapter source dir" FORCE)
endfunction()

set(UNIFIED_RUNTIME_REPO "https://github.com/oneapi-src/unified-runtime.git")
# commit 0247d0966ca8c5d1e3245f375e48e6c997bed9af
# Merge: 675dd292 04ffc909
set(UNIFIED_RUNTIME_REPO "https://github.com/Bensuo/unified-runtime.git")
# commit 532a4ecb72da4876cef61a4ae4d638e27ad609d5
# Merge: 22962057 d944ff33
# Author: aarongreig <[email protected]>
# Date: Tue Oct 1 17:10:58 2024 +0100
# Merge pull request #2154 from npmiller/fix-graph-exce
# [CUDA][HIP] Fix exceptions throwing from adapter
set(UNIFIED_RUNTIME_TAG 0247d0966ca8c5d1e3245f375e48e6c997bed9af)
# Date: Mon Sep 30 10:43:10 2024 +0100
# Merge pull request #1924 from Bensuo/fabio/cmd_buffer_kernel_update
# Add support for command-buffer kernel updates
set(UNIFIED_RUNTIME_TAG 6acd91a7d300d9c305c8789fb1f0a30391e52e2a)

set(UMF_BUILD_EXAMPLES OFF CACHE INTERNAL "EXAMPLES")
# Due to the use of dependentloadflag and no installer for UMF and hwloc we need
Expand Down
2 changes: 1 addition & 1 deletion sycl/source/detail/graph_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1474,7 +1474,7 @@ void exec_graph_impl::updateImpl(std::shared_ptr<node_impl> Node) {
}
}

UpdateDesc.hNewKernel = UrKernel;
UpdateDesc.hNewKernel = nullptr;
UpdateDesc.numNewMemObjArgs = MemobjDescs.size();
UpdateDesc.pNewMemObjArgList = MemobjDescs.data();
UpdateDesc.numNewPointerArgs = PtrDescs.size();
Expand Down
Loading