Skip to content

Conversation

@GeorgeWeb
Copy link
Contributor

@GeorgeWeb GeorgeWeb commented Oct 4, 2024

These tests failed on non Cuda or Hip host machines due to missing installations. Additionally, the -only-needed tests don't need libspirv so passing -fno-sycl-libspirv to the invocation is also required to succeed.

@GeorgeWeb GeorgeWeb requested a review from a team as a code owner October 4, 2024 15:48
@MartinWehking
Copy link
Contributor

LGTM. Thanks!

@GeorgeWeb GeorgeWeb changed the title [SYCL][Driver] Fix sycl-device-lib test failures when not building with Cuda or HIP backends [SYCL][Driver] Fix sycl-device-lib test failures when not targeting NVPTX or AMDGPU Oct 6, 2024
@GeorgeWeb GeorgeWeb changed the title [SYCL][Driver] Fix sycl-device-lib test failures when not targeting NVPTX or AMDGPU [SYCL][Driver] Fix sycl-device-lib test failures for non NVPTX or AMDGPU builds of DPC++ Oct 6, 2024
@GeorgeWeb
Copy link
Contributor Author

@intel/llvm-gatekeepers This looks ready to merge, if possible. Thanks!

@steffenlarsen steffenlarsen merged commit 9995592 into intel:sycl Oct 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants