[SYCL] Correctly spell out SM version macro when AOT compiling #15615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a typo resulting in the compiler using `*_SM[0-9][9-9]__` format when the SM was not supported: `#define __SYCL_TARGET_NVIDIA_GPU_SM50__ 0` vs: `#define __SYCL_TARGET_NVIDIA_GPU_SM_50__ 1` for the supported SM version. Prefer the underscore (`*_SM_[0-9][9-9]__`), as this is what CUDA uses, for example when specifying `gpu-name` switch for `ptxas`.
Contributor
Author
|
Fixes: #15545 |
sergey-semenov
approved these changes
Oct 8, 2024
Contributor
Author
|
@intel/llvm-gatekeepers this should be ready to roll. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a typo resulting in the compiler using
*_SM[0-9][9-9]__format when the SM was not supported:#define __SYCL_TARGET_NVIDIA_GPU_SM50__ 0vs:
#define __SYCL_TARGET_NVIDIA_GPU_SM_50__ 1for the supported SM version.
Prefer the underscore (
*_SM_[0-9][9-9]__), as this is what CUDA uses, for example when specifyinggpu-nameswitch forptxas.