Skip to content

[SYCL][NATIVECPU] Implement missing work group collectives in Native CPU libdevice #15618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2024
Merged

[SYCL][NATIVECPU] Implement missing work group collectives in Native CPU libdevice #15618

merged 1 commit into from
Oct 9, 2024

Conversation

@PietroGhg
Copy link
Contributor

@PietroGhg PietroGhg commented Oct 7, 2024 •
edited
Loading

Fixes some issues in Native CPU's libdevice:

  • Remove an unused definition of DefineBroadCastImpl
  • Fix typo in DefineBroadCastImpl that lead to incorrect results for broadcast
  • Define __spirv_GroupAny/ __spirv_GroupAll for work groups

@PietroGhg PietroGhg requested a review from a team as a code owner October 7, 2024 13:11
@PietroGhg
Copy link
Contributor Author

PietroGhg commented Oct 9, 2024

@intel/llvm-gatekeepers this looks ready to merge, thank you

@sommerlukas sommerlukas merged commit 1d58d6b into intel:sycl Oct 9, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@uwedolinsky uwedolinsky uwedolinsky approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PietroGhg @uwedolinsky @sommerlukas