Skip to content

Conversation

@againull
Copy link
Contributor

@againull againull commented Oct 9, 2024

Extension: sycl_ext_oneapi_get_kernel_info

Outlined kernel::attributes test to a separate file with existing XFAIL markings as it is the only descriptor which has a problem (GSD-8971) and reenabled kernel_info.cpp for other descriptors.

Extension: https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/proposed/sycl_ext_oneapi_get_kernel_info.asciidoc

Outlined kernel::attributes test to a separate file with XFAIL markings and reenabled
kernel_info.cpp.
@againull againull marked this pull request as ready for review October 9, 2024 22:55
@againull againull requested review from a team as code owners October 9, 2024 22:55
@againull againull requested a review from uditagarwal97 October 9, 2024 22:55
Copy link
Contributor

@uditagarwal97 uditagarwal97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@againull
Copy link
Contributor Author

@gmlueck Could you please take another look, thanks in advance!

@againull againull merged commit ca5cc18 into intel:sycl Oct 15, 2024
13 checks passed
@sarnex
Copy link
Contributor

sarnex commented Oct 15, 2024

@againull Seeing this fail in postcommit, can you please take a look? Thanks
https://github.com/intel/llvm/actions/runs/11350085536/job/31568113561

-- Testing: 2212 tests, 24 workers --
FAIL: SYCL :: no-xfail-without-tracker.cpp (2121 of 2212)
******************** TEST 'SYCL :: no-xfail-without-tracker.cpp' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 26
grep -rI "XFAIL:" /__w/llvm/llvm/llvm/sycl/test-e2e -A 1 --include=*.c --include=*.cpp      --no-group-separator |  grep -v "XFAIL:" |  grep -Pv "XFAIL-TRACKER:\s+(?:[https://github.com/[\w\d-]+/[\w\d-]+/issues/[\d]+)](https://github.com/[/w/d-]+/[/w/d-]+/issues/[/d]+))|(?:[\w]+-[\d]+)" |  wc -l | /__w/llvm/llvm/toolchain/bin/FileCheck /__w/llvm/llvm/llvm/sycl/test-e2e/no-xfail-without-tracker.cpp --check-prefix NUMBER-OF-XFAIL-WITHOUT-TRACKER
# executed command: grep -rI XFAIL: /__w/llvm/llvm/llvm/sycl/test-e2e -A 1 '--include=*.c' '--include=*.cpp' --no-group-separator
# note: command had no output on stdout or stderr
# executed command: grep -v XFAIL:
# note: command had no output on stdout or stderr
# executed command: grep -Pv 'XFAIL-TRACKER:\s+(?:[https://github.com/[\w\d-]+/[\w\d-]+/issues/[\d]+)](https://github.com/[/w/d-]+/[/w/d-]+/issues/[/d]+))|(?:[\w]+-[\d]+)'
# note: command had no output on stdout or stderr
# executed command: wc -l
# note: command had no output on stdout or stderr
# executed command: /__w/llvm/llvm/toolchain/bin/FileCheck /__w/llvm/llvm/llvm/sycl/test-e2e/no-xfail-without-tracker.cpp --check-prefix NUMBER-OF-XFAIL-WITHOUT-TRACKER
# .---command stderr------------
# | /__w/llvm/llvm/llvm/sycl/test-e2e/no-xfail-without-tracker.cpp:50:37: error: NUMBER-OF-XFAIL-WITHOUT-TRACKER: expected string not found in input
# | // NUMBER-OF-XFAIL-WITHOUT-TRACKER: 179
# |                                     ^
# | <stdin>:1:1: note: scanning from here
# | 178
# | ^
# | 
# | Input file: <stdin>
# | Check file: /__w/llvm/llvm/llvm/sycl/test-e2e/no-xfail-without-tracker.cpp
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# |           1: 178 
# | check:50     X~~~ error: no match found
# | >>>>>>
# `-----------------------------
# error: command failed with exit status: 1

@againull
Copy link
Contributor Author

@againull Seeing this fail in postcommit, can you please take a look? Thanks https://github.com/intel/llvm/actions/runs/11350085536/job/31568113561

-- Testing: 2212 tests, 24 workers --
FAIL: SYCL :: no-xfail-without-tracker.cpp (2121 of 2212)
******************** TEST 'SYCL :: no-xfail-without-tracker.cpp' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 26
grep -rI "XFAIL:" /__w/llvm/llvm/llvm/sycl/test-e2e -A 1 --include=*.c --include=*.cpp      --no-group-separator |  grep -v "XFAIL:" |  grep -Pv "XFAIL-TRACKER:\s+(?:[https://github.com/[\w\d-]+/[\w\d-]+/issues/[\d]+)](https://github.com/[/w/d-]+/[/w/d-]+/issues/[/d]+))|(?:[\w]+-[\d]+)" |  wc -l | /__w/llvm/llvm/toolchain/bin/FileCheck /__w/llvm/llvm/llvm/sycl/test-e2e/no-xfail-without-tracker.cpp --check-prefix NUMBER-OF-XFAIL-WITHOUT-TRACKER
# executed command: grep -rI XFAIL: /__w/llvm/llvm/llvm/sycl/test-e2e -A 1 '--include=*.c' '--include=*.cpp' --no-group-separator
# note: command had no output on stdout or stderr
# executed command: grep -v XFAIL:
# note: command had no output on stdout or stderr
# executed command: grep -Pv 'XFAIL-TRACKER:\s+(?:[https://github.com/[\w\d-]+/[\w\d-]+/issues/[\d]+)](https://github.com/[/w/d-]+/[/w/d-]+/issues/[/d]+))|(?:[\w]+-[\d]+)'
# note: command had no output on stdout or stderr
# executed command: wc -l
# note: command had no output on stdout or stderr
# executed command: /__w/llvm/llvm/toolchain/bin/FileCheck /__w/llvm/llvm/llvm/sycl/test-e2e/no-xfail-without-tracker.cpp --check-prefix NUMBER-OF-XFAIL-WITHOUT-TRACKER
# .---command stderr------------
# | /__w/llvm/llvm/llvm/sycl/test-e2e/no-xfail-without-tracker.cpp:50:37: error: NUMBER-OF-XFAIL-WITHOUT-TRACKER: expected string not found in input
# | // NUMBER-OF-XFAIL-WITHOUT-TRACKER: 179
# |                                     ^
# | <stdin>:1:1: note: scanning from here
# | 178
# | ^
# | 
# | Input file: <stdin>
# | Check file: /__w/llvm/llvm/llvm/sycl/test-e2e/no-xfail-without-tracker.cpp
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# |           1: 178 
# | check:50     X~~~ error: no match found
# | >>>>>>
# `-----------------------------
# error: command failed with exit status: 1

Yes, here is the fix: #15709

sarnex pushed a commit that referenced this pull request Oct 15, 2024
Tracker was added to one of the tests here:
#15650
so total number of tests without a tracker need to be reduced.
@againull againull deleted the get_kernel_info branch September 29, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants