Skip to content

Conversation

@sarnex
Copy link
Contributor

@sarnex sarnex commented Oct 10, 2024

Can cause build to fail if using -Werror, so disable the warning.

@sarnex sarnex marked this pull request as ready for review October 10, 2024 15:04
@sarnex sarnex requested a review from a team as a code owner October 10, 2024 15:04
@bader
Copy link
Contributor

bader commented Oct 10, 2024

Fix -> Disable.

What is the root cause of the warning?

@sarnex
Copy link
Contributor Author

sarnex commented Oct 10, 2024

We need to set some math flags in the test, and if you set some that are not compatible with the selected fp model, you get a warning and the model is overriden.

In our internal compiler, we set -fcomplex-arithmetic=promoted by default, and the options in this test cause it to be dropped to -fcomplex-arithmetic=basic, so we get this warning:

error: overriding '-fcomplex-arithmetic=promoted' option with '-fcomplex-arithmetic=basic' [-Werror,-Woverriding-option]

@sarnex sarnex changed the title [SYCL][ESIMD][E2E] Fix warning in fast math test [SYCL][ESIMD][E2E] Disable warning in fast math test Oct 10, 2024
@bader
Copy link
Contributor

bader commented Oct 10, 2024

Are you saying that the compiler always returns a warning if -ffast-math is set? This sounds like a problem we better fix rather than ignore.

@sarnex
Copy link
Contributor Author

sarnex commented Oct 10, 2024

It seems yes. I'll make an internal tracker, but since we are already testing with Werror, I think this workaround is worth submitting until the bigger issue is fixed

@sarnex
Copy link
Contributor Author

sarnex commented Oct 10, 2024

It seems this will be fixed quickly internally, so closing this

@sarnex sarnex closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants