[SYCL][NFC] Optmize handler.hpp compilation for device [2/N] #15698
+108
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved some of the code under `#ifndef __SYCL_DEVICE_ONLY__`, because it is related to various runtime checks, namely: - `throwOnLocalAccessorMisuse` - `checkIfPlaceholderIsBoundToHandler` - `throwIfGraphAssociated` This should reduce amount of template insantiations which are performed during device compilation. Note that implementation of a couple of `memcpy` methods was made completely host-only.
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dm-vodopyanov
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved some of the code under
#ifndef __SYCL_DEVICE_ONLY__, because it is related to various runtime checks, namely:throwOnLocalAccessorMisusecheckIfPlaceholderIsBoundToHandlerthrowIfGraphAssociatedThis should reduce amount of template insantiations which are performed during device compilation.
Note that implementation of a couple of
memcpymethods were made completely host-only.