[SYCL] Disallow passing kernel by value for sycl_kernel attribute #15702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreiZibrov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AndreiZibrov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
clang/lib/Sema/SemaSYCL.cpp
Outdated
|
|
||
| // SYCL 1.2.1 | ||
| return KernelParamTy.getUnqualifiedType(); | ||
| assert(KernelParamTy->isReferenceType() && "Since SYCL 2020 kernels must be passed by reference."); |
There was a problem hiding this comment.
I'm not a fan of the assert message. I think you can just say kernel must be passed by reference.
There was a problem hiding this comment.
I've changed it back. It seems like this assert gets hit before we issue a proper diagnostic for this kind of misuse.
clang/lib/Sema/SemaSYCL.cpp
Outdated
| if (! KernelParamTy->isReferenceType()) { | ||
| // passing by value. emit warning if using SYCL 2020 or greater | ||
| if (SemaRef.LangOpts.getSYCLVersion() >= LangOptions::SYCL_2020) | ||
| Diag(KernelFunc->getLocation(), diag::warn_sycl_pass_by_value_deprecated); |
There was a problem hiding this comment.
If we still have a diagnostic for deprecation for this case, you cannot assert in GetSYCLKernelObjectType
There was a problem hiding this comment.
I've changed this to be an error. That said, even with it being an error, it is still checked later than the assert, so I am still on the side of no assertions.
Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
steffenlarsen
changed the title
Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maarquitos14
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously (SYCL 1.2.1) kernel functions could be passed by value to
sycl_kernelannotated functions. However, this functionality has been deprecated for a while and the runtime no longer has any interfaces allowing by-value kernel function passing. As such, we can be stricter about this argument requirement.