[SYCL][LowerWGScope][SpecConstantsPass] fix new call's calling conv for spir/spirv

[wenju-he]

Newly created non-kernel function and function call should have spirv_func calling convention.

[wenju-he]

one motivation is intel gpu backend requires calling conv to be consistent.

[sarnex]

Suggested change

	if (TT.isSPIR())
	if (TT.isSPIROrSPIRV())

same for other spot too i think

[wenju-he]

done
Also fixed SpecConstantsPass

[asudarsa]

one motivation is intel gpu backend requires calling conv to be consistent.

Thanks for adding this support. Looks good. One question. Is there documentation anywhere that talks about this calling convention and about which functions need this. Surely not a blocker. Thanks

[sarnex]

lgtm as in my feedback is addressed, thx

[wenju-he]

one motivation is intel gpu backend requires calling conv to be consistent.

Thanks for adding this support. Looks good. One question. Is there documentation anywhere that talks about this calling convention and about which functions need this. Surely not a blocker. Thanks

@asudarsa For spir target, quote from page 33 of https://registry.khronos.org/SPIR/specs/spir_spec-2.0.pdf

3.8 Calling Conventions
SPIR kernels should use "spir_kernel" calling convention. Non-kernel functions use "spir_func"
calling convention. All other calling conventions are disallowed.

So I assume every function call should have either spir_kernel or spir_func calling convention.

I am not ware of any documentation of the requirement of consistent calling convention in the intel gpu backend.

[wenju-he]

@intel/llvm-gatekeepers please merge, thank you