[SYCL][Matrix] Add W/A for several corner cases of AccessChain usage #15738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These corner cases are: 1. AccessChain uses are optimized out of LLVM IR modules, leaving the call unused; 2. AccessChain result is used in GEP 0,0 instruction for bfloat16 (instead of the immidiate use by load or store). All of these issues are or will be fixed in our drivers, but since the cadence of the driver update is relatively big the W/A is added in the frontend for an immediate fix. Signed-off-by: Sidorov, Dmitry <[email protected]>
MrSidims
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
llvm/test/SYCLLowerIR/JointMatrixTransform/access-chain-no-uses.ll
Outdated
Show resolved
Hide resolved
llvm/test/SYCLLowerIR/JointMatrixTransform/access_chain_bf16.ll
Outdated
Show resolved
Hide resolved
Sure, I can open it. But first I need to create a tracker to say, that the issue exists in the first place... |
MrSidims
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
MrSidims
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
MrSidims
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
approved these changes
Oct 17, 2024
Signed-off-by: Sidorov, Dmitry <[email protected]>
MrSidims
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
MrSidims
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
approved these changes
Oct 18, 2024
I've created an internal tracker for this. |
maarquitos14
approved these changes
Oct 18, 2024
|
@intel/llvm-gatekeepers please help with the merge |
|
No idea, probably some issue on Github's end, I'll keep trying. |
|
Still stuck, hopefully it fixes itself lol |
|
we did it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These corner cases are:
All of these issues are or will be fixed in our drivers, but since the cadence of the driver update is relatively big the W/A is added in the frontend for an immediate fix.