[POC] [DO NOT MERGE/JUDGE] std::nan support cmath in device only code. #15771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s. At first I thought this impossible. But then...
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Contributor
Author
|
The tests that are failing are failing because I've only done this stunt for the double nan. Not half or the other types yet. |
| constexpr double NanAbuse = std::numeric_limits<double>::quiet_NaN(); | ||
| } | ||
|
|
||
| #define nan(x) NanAbuse |
Contributor
There was a problem hiding this comment.
I don't think that's acceptable. NaN value must be as specified in the string.
Contributor
Author
There was a problem hiding this comment.
No two NaNs are ever equal. Even std::nan("1") and std::nan("1") so it doesn't matter what the value is, so long as it is NaN. In practice, supposedly some people can use the strings to disambiguate NaN values in the debugger, to help understand their provenance, but this is entirely outside the scope.
Contributor
There was a problem hiding this comment.
There is always std::bit_cast...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users are wanting to reuse kernel code that contains
std::nan("str");declarations. At first I thought this impossible. But then...