-
Notifications
You must be signed in to change notification settings - Fork 796
[SYCL][NFC] Introduce unit-tests for ONEAPI_DEVICE_SELECTOR
#15774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][NFC] Introduce unit-tests for ONEAPI_DEVICE_SELECTOR
#15774
Conversation
There are E2E tests which are essentially testing the correctness of `ONEAPI_DEVICE_SELECTOR` env variable testing, but that can be done in way more efficient way which is unit-tests. Note that this PR does not aim to cover `ONEAPI_DEVICE_SELECTOR` parsing with unit-tests in full, but rather aims to replace the most obvious candidates from E2E tests with unit-tests, providing some foundation for expanding unit-tests in follow-up PRs.
|
I had a failure in the first run of unittests on Windows, which looked like: I'm sure that it couldn't be caused by changes in the PR, I wasn't able to reproduce it locally and it passed on the restart. I will cancel remaining Windows E2E tests job, because those tests shouldn't be affected by the PR and they passed in the first run, logs here. With that said, pre-commit seems to be passing for the PR and I will proceed with merge |
There are E2E tests which are essentially testing the correctness of
ONEAPI_DEVICE_SELECTORenv variable testing, but that can be done in way more efficient way which is unit-tests.Note that this PR does not aim to cover
ONEAPI_DEVICE_SELECTORparsing with unit-tests in full, but rather aims to replace the most obvious candidates from E2E tests with unit-tests, providing some foundation for expanding unit-tests in follow-up PRs.