[SYCL][NFCI] Unify queue submit paths #15776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The submit method on queue has caused multiple divergences throughout its lifetime, when additional information was required for new functionality. However, that design means an exponential growth in functions every time a new optional argument is needed. To battle this, this patch adds a new pimpl class with the optional submission info, which will only be initialized if needed. This boils the submit function paths down to one with event and one without. Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Friendly ping @intel/llvm-reviewers-runtime (@bso-intel) |
1 similar comment
|
Friendly ping @intel/llvm-reviewers-runtime (@bso-intel) |
Comment on lines
+2784
to
+2785
| const detail::code_location &CodeLoc, | ||
| bool IsTopCodeLoc); |
There was a problem hiding this comment.
Why aren't these two part of SubmitInfo? Maybe even CGH itself should go there...
There was a problem hiding this comment.
The intention was for SubmissionInfo to be "free" if none of the optional arguments were passed. I suppose it could be part of the SubmissionInfo class itself, rather than its impl. Is that what you were thinking?
Of course, if there are non-optional arguments added in the future, we either have to add them to the impl of SubmissionInfo anyway, break ABI or add yet another API.
Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
bso-intel
approved these changes
Nov 7, 2024
Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
commented
Nov 11, 2024
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
approved these changes
Nov 14, 2024
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The submit method on queue has caused multiple divergences throughout its lifetime, when additional information was required for new functionality. However, that design means an exponential growth in functions every time a new optional argument is needed. To battle this, this patch adds a new pimpl class with the optional submission info, which will only be initialized if needed. This boils the submit function paths down to one with event and one without.