Skip to content

Deprecate intel reqd sub group size #15798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 29, 2024
Merged

Deprecate intel reqd sub group size #15798

merged 11 commits into from
Oct 29, 2024

Conversation

@dklochkov-emb
Copy link
Contributor

@dklochkov-emb dklochkov-emb commented Oct 22, 2024

  1. [[intel::reqd_sub_group_size]] was made deprecated. Warning will be raised when it is used
  2. Test to check warning was added into separate file (tests/warnings_deprecated.cpp) because tests/warnings.cpp contains flag to ignore deprecated warnings
  3. Test to check modern attribute - [[sycl::reqd_sub_group_size]] - was added to check that no one warning was raised
  4. Changes to use modern [[sycl::reqd_sub_group_size]] in tests were done
  5. Some of the tests named sub-group-size got compiler flag to ignore new warning

@dklochkov-emb dklochkov-emb requested review from a team as code owners October 22, 2024 08:58
AlexeySachkov
AlexeySachkov approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@AlexeySachkov AlexeySachkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to sycl/test-e2e/AOT LGTM.

Alcpz
Alcpz approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@Alcpz Alcpz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SYCLcompat tests changes LGTM

sarnex
sarnex approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

esimd/tools lgtm

dkhaldi
dkhaldi approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JM changes LGTM

@AlexeySachkov AlexeySachkov mentioned this pull request Oct 23, 2024
Merged
elizabethandrews
elizabethandrews reviewed Oct 24, 2024
View reviewed changes
elizabethandrews
elizabethandrews reviewed Oct 25, 2024
View reviewed changes
@AlexeySachkov AlexeySachkov merged commit 2172d9e into intel:sycl Oct 29, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexeySachkov AlexeySachkov AlexeySachkov approved these changes

@sarnex sarnex sarnex approved these changes

@dkhaldi dkhaldi dkhaldi approved these changes

@sergey-semenov sergey-semenov sergey-semenov approved these changes

@elizabethandrews elizabethandrews elizabethandrews approved these changes

+2 more reviewers

@Alcpz Alcpz Alcpz approved these changes

@smanna12 smanna12 smanna12 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@dklochkov-emb @Alcpz @AlexeySachkov @sarnex @dkhaldi @sergey-semenov @elizabethandrews @smanna12