[SYCL][COMPAT] Add max_active_work_groups_per_cu #15802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I guess previously only being used places where already included
Related functionality already in this file
joeatodd
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
FMarno
reviewed
Oct 22, 2024
sycl/test-e2e/syclcompat/util/max_active_work_groups_per_cu.cpp
Outdated
Show resolved
Hide resolved
joeatodd
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AD2605
reviewed
Oct 22, 2024
| size_t max_wgs = kernel.template ext_oneapi_get_info< | ||
| syclex::info::kernel_queue_specific::max_num_work_groups>( | ||
| q, sycl::range<3>{syclcompat::dim3{wg_range}}, local_mem_size); | ||
| assert(max_per_cu == max_wgs / max_compute_units); |
There was a problem hiding this comment.
do we expect NDEBUG to not to defined during testing ?
Does the CI build and test DPCPP with a specific configuration or is the build type string left empty ?
There was a problem hiding this comment.
Yes, asserts work as expected during testing. llvm-lit will test on as many backends as are available, AFAIK.
AD2605
reviewed
Oct 22, 2024
AD2605
reviewed
Oct 22, 2024
Also reorder params to match the rest of syclcompat
joeatodd
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
joeatodd
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers this is ready to merge 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new API returns the maximum work-groups which can occupy a single compute unit of the given device.