[UR] Split the UNIFIED_RUNTIME_TAG to its own file #15809
Conversation
With current repo setup, we need to update UNIFIED_RUNTIME_TAG constantly. This is creating conflicts when doing merge from other branches. To faciliate the automation to handle such conflicts, we would prefer to split the tag into into own file, the automation will then be triggereed whenever the file changes (implying UR tag change).
|
What about the second separate file for the same set for the xisa build? |
Will be done in downstream branch only. |
There was a problem hiding this comment.
I think this change makes sense. As mentioned by @uditagarwal97 the .github/CODEOWNERS file must be updated, for example as follows which includes my suggested filename change:
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
--- a/.github/CODEOWNERS
+++ b/.github/CODEOWNERS
@@ -36,6 +36,7 @@ sycl/doc/extensions/ @intel/dpcpp-specification-reviewers
# Unified Runtime
sycl/cmake/modules/FetchUnifiedRuntime.cmake @intel/unified-runtime-reviewers
+sycl/cmake/modules/FetchUnifiedRuntimeTag.cmake @intel/unified-runtime-reviewers
sycl/include/sycl/detail/ur.hpp @intel/unified-runtime-reviewers
sycl/source/detail/posix_ur.cpp @intel/unified-runtime-reviewers
sycl/source/detail/ur.cpp @intel/unified-runtime-reviewersThere was a problem hiding this comment.
I think this filename should have the Tag suffix rather than TAG.
Thanks @kbenzie and @uditagarwal97 . |
Co-authored-by: Udit Agarwal <[email protected]>
|
@intel/llvm-gatekeepers Can someone help to merge this. Thanks. |
|
@jsji I must be missing it, but I don't see how this solves the problem. Won't merge conflict problem just be moved to |
Yes, you are right, this is not trying to remove the conflict in the tag itself, but to facilitate the automation to help with resolving the conflicts. |
With current repo setup, we need to update UNIFIED_RUNTIME_TAG
constantly. This is creating conflicts when doing merge from other
branches. To faciliate the automation to handle such conflicts,
we would prefer to split the tag into into own file, the automation
will then be triggereed whenever the file changes (implying UR tag
change).