[SYCL] Implement device library linking for runtime compilation #15810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`llvm::Module` must remain qualified to resolve the ambiguity with `clang::Module`. Signed-off-by: Julian Oppermann <[email protected]>
Signed-off-by: Julian Oppermann <[email protected]>
Signed-off-by: Julian Oppermann <[email protected]>
jopperm
force-pushed
the
rtc-via-sycl-jit-device-linking
branch
from
8096e3e to
970b041
Compare
Signed-off-by: Julian Oppermann <[email protected]>
jopperm
commented
Oct 28, 2024
Comment on lines
-109
to
-158
| // TODO: Allow instrumentation again when device library linking is | ||
| // implemented. | ||
| CommandLine.push_back("-fno-sycl-instrument-device-code"); |
There was a problem hiding this comment.
NB: This PR is tested by the existing E2E test, which now works with device instrumentation enabled.
There was a problem hiding this comment.
Device instrumentation was disabled by default recently (#14910); I added the flag to one of the E2E test's user-supplied arguments.
jopperm
commented
Oct 28, 2024
Signed-off-by: Julian Oppermann <[email protected]>
sommerlukas
approved these changes
Oct 30, 2024
|
Reverted to draft while working on better handling of user arguments. |
Signed-off-by: Julian Oppermann <[email protected]>
Signed-off-by: Julian Oppermann <[email protected]>
Signed-off-by: Julian Oppermann <[email protected]>
Signed-off-by: Julian Oppermann <[email protected]>
Signed-off-by: Julian Oppermann <[email protected]>
jopperm
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Julian Oppermann <[email protected]>
jopperm
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Julian Oppermann <[email protected]>
jopperm
changed the title
…vice-linking Signed-off-by: Julian Oppermann <[email protected]>
jopperm
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@cperkinsintel @gmlueck @AlexeySachkov could you take a look, please? |
jopperm
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
approved these changes
Nov 14, 2024
Sorry, I can't commit to reviewing every PR for the jit compiler. I generally review changes to specifications, and I'm available to answer questions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mimics
clang::driver::tools::SYCL::getDeviceLibrariesassuming a SPIR-V target (= no AoT, no third-party GPUs, no native CPU).Same as for the compilation step, warning/error reporting is still rudimentary and will be improved in a future PR.