Skip to content

Conversation

@yanfeng3721
Copy link
Contributor

No description provided.

@yanfeng3721 yanfeng3721 requested a review from a team as a code owner October 23, 2024 09:01
@yanfeng3721 yanfeng3721 marked this pull request as draft October 23, 2024 09:01
@yanfeng3721 yanfeng3721 requested a review from tfzhu October 23, 2024 09:01
@yanfeng3721
Copy link
Contributor Author

Waiting for oneTBB 2022.0 public release in https://github.com/oneapi-src/oneTBB/releases.

@yanfeng3721 yanfeng3721 changed the title Uplift oclcpu/oclfpgaemu from 2024.17.3.0.09 to 2024.18.10.0.08 [CI] Uplift oclcpu/oclfpgaemu from 2024.17.3.0.09 to 2024.18.10.0.08 Nov 1, 2024
@zhaomaosu
Copy link
Contributor

Hi @yanfeng3721, looks like TBB 2022.0 is released. Is there any other blocking issue for this PR?

@yanfeng3721
Copy link
Contributor Author

Hi @yanfeng3721, looks like TBB 2022.0 is released. Is there any other blocking issue for this PR?

Hi @zhaomaosu , yes, the PR failed to pass sycl-ls check, could not detect oclcpu 2024.18.10.0.08

Run sycl-ls --verbose
[level_zero:gpu][level_zero:0] Intel(R) oneAPI Unified Runtime over Level-Zero, Intel(R) Iris(R) Xe Graphics [12](https://github.com/intel/llvm/actions/runs/11623185850/job/33174845944?pr=15827#step:17:13).0.0 [1.6.31294.120000]
[opencl:gpu][opencl:0] Intel(R) OpenCL Graphics, Intel(R) Iris(R) Xe Graphics OpenCL 3.0 NEO  [24.39.31294.12]
[native_cpu:cpu][native_cpu:0] SYCL_NATIVE_CPU, SYCL Native CPU 0.1 [0.0.0]
 the TBB 2022.0.0  and oclcpu 2024.18.10.0.08 package works

Hi @sarnex , since we have tried TBB 2022.0.0 and oclcpu oclcpu 2024.18.10.0.08 package locally and it works fine, could you please take a look why the deps does not work for intel/llvm CI? Thanks.

@yanfeng3721 yanfeng3721 requested a review from sarnex November 19, 2024 06:34
@sarnex
Copy link
Contributor

sarnex commented Nov 19, 2024

I'll take a look.

@sarnex
Copy link
Contributor

sarnex commented Nov 19, 2024

@yanfeng3721 @zhaomaosu

EDIT: I screwed up the investigation. The problem is the oneTBB 2022 install is not going into the right folder. Let me try to fix it.

@sarnex
Copy link
Contributor

sarnex commented Nov 19, 2024

@zhaomaosu @yanfeng3721 I fixed the problem and pushed it to your branch, hopefully that was ok. All the tests passed too, so if you guys are ready I think this PR is ready for merge.

@zhaomaosu
Copy link
Contributor

Thanks @sarnex for your quick fix!

@yanfeng3721 yanfeng3721 marked this pull request as ready for review November 20, 2024 01:58
@yanfeng3721
Copy link
Contributor Author

yanfeng3721 commented Nov 20, 2024

Thanks @sarnex , the new cpurt works fine now, please also help to merge the PR.

@sarnex sarnex merged commit 090c9f3 into intel:sycl Nov 20, 2024
18 checks passed
@sarnex
Copy link
Contributor

sarnex commented Nov 20, 2024

Merged, thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants