[SYCL][E2E] Fix Basic/kernel_info_attr.cpp test #15837
Conversation
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| assert(krnAttr.empty() || | ||
| krnAttr == "intel_reqd_workgroup_walk_order(0,1,2)"); |
There was a problem hiding this comment.
@gmlueck is this legal behavior for the implementation to attach some attributes implicitly?
There was a problem hiding this comment.
I agree that it's weird, especially since intel_reqd_workgroup_walk_order isn't documented. It seems like intel_reqd_workgroup_walk_order is more of an implementation detail, rather than a user-visible attribute. Given that, it seems like it might be better to not return it from get_info<info::kernel::attributes>(). Would that be easy to do?
On the other hand, the SYCL spec doesn't define the format of the string returned from get_info<info::kernel::attributes>(), so the current behavior won't cause us to fail conformance.
There was a problem hiding this comment.
I see your point. It seems that this at least breaks conformance with OpenCL spec as it says the following about CL_KERNEL_ATTRIBUTES:
Returns any attributes specified using the attribute OpenCL C qualifier (or using an OpenCL C++ qualifier syntax [[]] ) with the kernel function declaration in the program source.
Currently gpu driver returns intel_reqd_workgroup_walk_order even though nothing is attached.
So, problem should be fixed at gpu driver level to not return internal attributes for corresponding queries.
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
3 participants
No description provided.