-
Notifications
You must be signed in to change notification settings - Fork 796
[SYCL][E2E] Add granularity test for sycl_ext_oneapi_virtual_mem extension
#15848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][E2E] Add granularity test for sycl_ext_oneapi_virtual_mem extension
#15848
Conversation
maarquitos14
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I'm misreading the testplan, but it seems to me it says this test should be unittest not e2e test. @AlexeySachkov can you confirm?
Sorry for the confusion here. I should probably use a different terminology in the test plan, but due to the lack of a better one we have what we have. Suggestions are welcome, BTW! Back to the question: even though the test plan says "unit", not all tests under that category are expected to be unit-tests in our regular understanding (i.e. put into The main thing I wanted to highlight by the word "unit" is that we are not trying to test a proper meaningful usage scenario, but instead we just check internal consistency and correctness of certain APIs in isolation. That is done to have a better granularity in tests, so that when something breaks, we know the exact API which got broken and we don't have to debug a whole mini-application to understand why results are incorrect at the end. This particular test should still stay E2E - moving it to |
Co-authored-by: Alexey Sachkov <[email protected]>
Co-authored-by: Marcos Maronas <[email protected]>
|
Thanks for the clarification, @AlexeySachkov, that makes sense. |
maarquitos14
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a nit.
|
@intel/llvm-gatekeepers I would appreciate if this PR could be merged. |
Based on the test plan #15509, this PR adds an e2e test checking memory granularities returned by
get_mem_granularity.