Skip to content
2 changes: 1 addition & 1 deletion sycl/test-e2e/Assert/assert_in_kernels.cpp
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// REQUIRES: linux

// https://github.com/intel/llvm/issues/7634
// UNSUPPORTED: hip
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/7634
//
// XFAIL: (opencl && gpu)
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/11364
Expand Down
6 changes: 3 additions & 3 deletions sycl/test-e2e/Assert/assert_in_multiple_tus.cpp
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
// REQUIRES: linux

// https://github.com/intel/llvm/issues/7634
// UNSUPPORTED: hip
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/7634
//
// https://github.com/intel/llvm/issues/8832
// UNSUPPORTED: cuda
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/8832
//
// XFAIL: (opencl && gpu)
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/11364

// https://github.com/intel/llvm/issues/15029
// UNSUPPORTED: gpu-intel-dg2
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/15029

// RUN: %{build} -DSYCL_FALLBACK_ASSERT=1 -I %S/Inputs %S/Inputs/kernels_in_file2.cpp -o %t.out
// RUN: %{run} %t.out &> %t.txt ; FileCheck %s --input-file %t.txt %if fpga %{ --check-prefix=CHECK-ACC %}
Expand Down
4 changes: 2 additions & 2 deletions sycl/test-e2e/Assert/assert_in_multiple_tus_one_ndebug.cpp
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
// REQUIRES: linux

// https://github.com/intel/llvm/issues/7634
// UNSUPPORTED: hip
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/7634
//
// https://github.com/intel/llvm/issues/8832
// UNSUPPORTED: cuda
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/8832
//
// XFAIL: (opencl && gpu)
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/11364
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/Assert/assert_in_one_kernel.cpp
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// REQUIRES: linux

// https://github.com/intel/llvm/issues/7634
// UNSUPPORTED: hip
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/7634
//
// XFAIL: (opencl && gpu)
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/11364
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// FIXME flaky fail on CUDA
// FIXME HIP: https://github.com/intel/llvm/issues/7634
// UNSUPPORTED: cuda, hip
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/7634
//
// XFAIL: (opencl && gpu)
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/11364
Expand Down
3 changes: 3 additions & 0 deletions sycl/test-e2e/Basic/kernel_max_wg_size.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
// https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/experimental/sycl_ext_intel_grf_size.asciidoc
// REQUIRES: arch-intel_gpu_pvc || gpu-intel-dg2
// UNSUPPORTED: cuda || hip
// UNSUPPORTED-INTENDED: This extension is currently implemented in DPC++ only
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to the main change in the PR, but tagging @sarnex here. I'm not sure if having an optional property unguarded by an aspect is a good interface for end users. Even if we don't introduce an aspect, can we update the spec to say that submitting a kernel with grf property to a device and/or using a backend which doesn't support that results in an exception? This way we would be able to rewrite the test to avoid use of `UNSUPPORTED.

Moreover, we have REQUIRES which points to specific GPUs, do we even need UNSUPPORTED in that case?

// for Intel GPU devices and only when using the Level Zero backend or OpenCL
// backend.

// clang-format off
#include <sycl/detail/core.hpp>
Expand Down
26 changes: 26 additions & 0 deletions sycl/test-e2e/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -343,3 +343,29 @@ Once the issue is created, you can update the test by adding `XFAIL` and

If you add `XFAIL` without `XFAIL-TRACKER` directive,
`no-xfail-without-tracker.cpp` test will fail, notifying you about that.

## Marking tests as unsupported

Some tests may be considered unsupported, e.g.:
* the test checks the feature that is not supported by some
backend / device / OS / etc.
* the test is flaky or hangs, so it can't be marked with `XFAIL`.

In these cases the test can be marked with `UNSUPPORTED`. This mark should be
followed by either `UNSUPPORTED-INTENDED` or `UNSUPPORTED-TRACKER` depending on
whether the test is not intended to be run with some feature at all or it was
temporarily disabled due to some issue.
```
// UNSUPPORTED: cuda, hip
// UNSUPPORTED-INTENDED: only supported by backends with SPIR-V IR

// Sporadically fails on DG2.
// UNSUPPORTED: gpu-intel-dg2
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/DDDDD
// *OR*
// UNSUPPORTED-TRACKER: PRJ-1234
```

If you add `UNSUPPORTED` without `UNSUPPORTED-TRACKER` or `UNSUPPORTED-INTENDED`
directive, the `no-unsupported-without-tracker.cpp` test will fail, notifying
you about that.
548 changes: 548 additions & 0 deletions sycl/test/e2e_test_requirements/no-unsupported-without-info.cpp

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// This test is intended to ensure that we have no trackers marked as XFAIL
// This test is intended to ensure that we have no tests marked as XFAIL
// without a tracker information added to a test.
// For more info see: sycl/test-e2e/README.md
//
// The format we check is:
// XFAIL: lit,features
Expand Down
Loading