[DeviceAsan][NFC] Fix ASan e2e tests, enable CPU or GPU tests #15869

AllanZyne · 2024-10-25T03:22:07Z

Update lit config to make sure tests will run on cpu or gpu device
disable GEN12 test

wenju-he · 2024-10-25T08:33:52Z

sycl/test-e2e/AddressSanitizer/bad-free/bad-free-host.cpp

@@ -1,4 +1,4 @@
-// REQUIRES: linux
+// REQUIRES: linux, cpu || (gpu && level_zero)


level_zero implies gpu, right?

No. Intel NPU device is exposed as Level Zero device as well.

AllanZyne · 2024-10-30T08:08:08Z

@AllanZyne - Runtime review isn't needed, so you have all the approvals you need.

That said, before we can merge this, you need to remove sycl/test-e2e/AddressSanitizer/nullpointer/global_nullptr.cpp from sycl/test/e2e_test_requirements/no-unsupported-without-info.cpp and decrement the expected number of unsupported tests in that file. That may require runtime approval, so I'll give you that preemptively.

Thanks, updated.

AllanZyne · 2024-10-31T02:14:33Z

@intel/llvm-gatekeepers, please merge, thanks!

AllanZyne · 2024-10-31T08:50:54Z

If I remember correctly, I pushed the last commit yesterday.
I think the CI test is hang.

steffenlarsen · 2024-10-31T10:04:28Z

If I remember correctly, I pushed the last commit yesterday. I think the CI test is hang.

CI failed, so I restarted it recently.

steffenlarsen · 2024-10-31T12:24:08Z

Tests do indeed seem to be running for a long time. @intel/llvm-gatekeepers - Is this something anyone else have observed? If not, we will have to assume that it is caused by the tests being enabled here, until we observe otherwise.

sarnex · 2024-10-31T14:16:35Z

Probably there is some hanging test here, we're not seeing this on other PRs. I cancelled the job here to not hog the CI.

@AllanZyne @intel/dpcpp-sanitizers-review Can someone try to reproduce a Gen12 Linux hang introduced by this PR? Thanks

yingcong-wu · 2024-11-01T01:31:14Z

Hi @sarnex @AllanZyne , We noticed that Device Address Sanitizer run into some weird problem with gen 12 and we suspect the problem is with IGC codegen. Therefore I suggest that we skip running on gen 12 for the moment.

AllanZyne · 2024-11-01T02:02:29Z

Hi @sarnex @AllanZyne , We noticed that Device Address Sanitizer run into some weird problem with gen 12 and we suspect the problem is with IGC codegen. Therefore I suggest that we skip running on gen 12 for the moment.

Sure, thank you for your investigation!

sycl/test-e2e/AddressSanitizer/lit.local.cfg

Co-authored-by: Steffen Larsen <[email protected]>

sarnex · 2024-11-04T15:11:55Z

Still seeing timeouts on Linux gen12 it seems.

AllanZyne · 2024-11-22T05:16:28Z

Still seeing timeouts on Linux gen12 it seems.

I have disable GEN12 test now.
I tested them on GEN12, and it seems there're some issues in igc/level0.

AllanZyne · 2024-11-25T08:04:06Z

Hi @intel/llvm-gatekeepers, please merge. Thanks.

AllanZyne requested review from a team as code owners October 25, 2024 03:22

AllanZyne requested a review from aelovikov-intel October 25, 2024 03:22

AllanZyne had a problem deploying to WindowsCILock October 25, 2024 03:22 — with GitHub Actions Failure

wip

6543647

AllanZyne force-pushed the review/yang/fix_asan_tests branch from be4cf3d to 6543647 Compare October 25, 2024 03:26

AllanZyne temporarily deployed to WindowsCILock October 25, 2024 03:26 — with GitHub Actions Inactive

AllanZyne removed request for a team October 25, 2024 03:27

AllanZyne temporarily deployed to WindowsCILock October 25, 2024 03:39 — with GitHub Actions Inactive

AllanZyne added 3 commits October 24, 2024 22:21

add pvc

3f46f8f

remove gpu type filter

c50b508

disable cpu

d891e59

AllanZyne temporarily deployed to WindowsCILock October 25, 2024 06:07 — with GitHub Actions Inactive

AllanZyne changed the title ~~[DeviceAsan][NFC] Fix ASan e2e tests, enable CPU or DG2 device only~~ [DeviceAsan][NFC] Fix ASan e2e tests, enable CPU or GPU tests Oct 25, 2024

fix compiler error

eb9ad33

AllanZyne had a problem deploying to WindowsCILock October 25, 2024 06:22 — with GitHub Actions Failure

AllanZyne had a problem deploying to WindowsCILock October 25, 2024 06:46 — with GitHub Actions Error

disable cpu

85f47f5

AllanZyne force-pushed the review/yang/fix_asan_tests branch from 85cafd3 to 85f47f5 Compare October 25, 2024 06:48

AllanZyne had a problem deploying to WindowsCILock October 25, 2024 06:48 — with GitHub Actions Error

AllanZyne mentioned this pull request Oct 25, 2024

AddressSanitizer/nullpointer/global_nullptr.cpp fails on DG2 #15453

Open

enable global_nullptr

c753a31

AllanZyne temporarily deployed to WindowsCILock October 25, 2024 07:00 — with GitHub Actions Inactive

AllanZyne temporarily deployed to WindowsCILock October 25, 2024 07:13 — with GitHub Actions Inactive

wenju-he reviewed Oct 25, 2024

View reviewed changes

fix

574e54e

AllanZyne temporarily deployed to WindowsCILock October 25, 2024 08:46 — with GitHub Actions Inactive

AllanZyne temporarily deployed to WindowsCILock October 30, 2024 08:05 — with GitHub Actions Inactive

AllanZyne temporarily deployed to WindowsCILock October 30, 2024 08:41 — with GitHub Actions Inactive

disable gen12

325470a

AllanZyne temporarily deployed to WindowsCILock November 1, 2024 02:55 — with GitHub Actions Inactive

AllanZyne temporarily deployed to WindowsCILock November 1, 2024 03:18 — with GitHub Actions Inactive

steffenlarsen reviewed Nov 1, 2024

View reviewed changes

sycl/test-e2e/AddressSanitizer/lit.local.cfg Outdated Show resolved Hide resolved

AllanZyne and others added 2 commits November 4, 2024 13:16

Update sycl/test-e2e/AddressSanitizer/lit.local.cfg

a972f3a

Co-authored-by: Steffen Larsen <[email protected]>

Merge branch 'sycl' into review/yang/fix_asan_tests

8338aca

AllanZyne temporarily deployed to WindowsCILock November 4, 2024 05:18 — with GitHub Actions Inactive

AllanZyne temporarily deployed to WindowsCILock November 4, 2024 05:41 — with GitHub Actions Inactive

AllanZyne added 2 commits November 21, 2024 18:03

Merge branch 'sycl' into review/yang/fix_asan_tests

95be6f7

"arch-intel_gpu_12_0_0" doesn't work

678655c

AllanZyne had a problem deploying to WindowsCILock November 22, 2024 02:14 — with GitHub Actions Error

Merge branch 'sycl' into review/yang/fix_asan_tests

7474cf7

AllanZyne temporarily deployed to WindowsCILock November 22, 2024 02:15 — with GitHub Actions Inactive

AllanZyne temporarily deployed to WindowsCILock November 22, 2024 02:31 — with GitHub Actions Inactive

AllanZyne mentioned this pull request Nov 25, 2024

AddressSanitizer e2e tests are likely to hang on GEN12 #15953

Open

martygrant merged commit 48730da into sycl Nov 25, 2024
13 checks passed

AllanZyne deleted the review/yang/fix_asan_tests branch November 25, 2024 09:29

		@@ -1,4 +1,4 @@
		// REQUIRES: linux
		// REQUIRES: linux, cpu \|\| (gpu && level_zero)

[DeviceAsan][NFC] Fix ASan e2e tests, enable CPU or GPU tests #15869

[DeviceAsan][NFC] Fix ASan e2e tests, enable CPU or GPU tests #15869

Uh oh!

Conversation

AllanZyne commented Oct 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wenju-he Oct 25, 2024

Choose a reason for hiding this comment

Uh oh!

bader Oct 25, 2024

Choose a reason for hiding this comment

Uh oh!

AllanZyne commented Oct 30, 2024

Uh oh!

AllanZyne commented Oct 31, 2024

Uh oh!

AllanZyne commented Oct 31, 2024

Uh oh!

steffenlarsen commented Oct 31, 2024

Uh oh!

steffenlarsen commented Oct 31, 2024

Uh oh!

sarnex commented Oct 31, 2024

Uh oh!

yingcong-wu commented Nov 1, 2024

Uh oh!

AllanZyne commented Nov 1, 2024

Uh oh!

Uh oh!

sarnex commented Nov 4, 2024

Uh oh!

AllanZyne commented Nov 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AllanZyne commented Nov 25, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

AllanZyne commented Oct 25, 2024 •

edited

Loading

AllanZyne commented Nov 22, 2024 •

edited

Loading