Skip to content

Conversation

@jinge90
Copy link
Contributor

@jinge90 jinge90 commented Oct 25, 2024

Add an new function in libdevice CMake to provide a way to pass arbitrary compiling flags when building a device library file. This is preparatory work to add AOT device asan library targeting for different GPU/CPU platforms.

@jinge90 jinge90 requested a review from a team as a code owner October 25, 2024 05:38
@jinge90 jinge90 requested a review from cperkinsintel October 25, 2024 05:38
@jinge90
Copy link
Contributor Author

jinge90 commented Oct 25, 2024

Hi, @MartinWehking
Could you help review this PR?
Thanks very much.

@jinge90
Copy link
Contributor Author

jinge90 commented Oct 25, 2024

Hi, @cperkinsintel
Could you help review this PR?
Thanks very much.

Copy link
Contributor

@cperkinsintel cperkinsintel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've never worked with devicelib, but this looks straightforward

@jinge90 jinge90 requested a review from a team October 29, 2024 00:34
@jinge90
Copy link
Contributor Author

jinge90 commented Oct 29, 2024

Hi, @intel/llvm-gatekeepers
Could you help merge this PR?
Thanks very much.

@steffenlarsen steffenlarsen merged commit b7ef830 into intel:sycl Oct 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants