-
Notifications
You must be signed in to change notification settings - Fork 796
[SYCL][E2E] Add more xfails to recently re-enabled test #15878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sarnex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx for fast fix
|
Can you add the link of the GH action that's failing? |
|
we should probably let the post commit ci finish before merging to see if there are any other extra failures |
| @@ -1,4 +1,4 @@ | |||
| // XFAIL: any-device-is-opencl, any-device-is-cuda, (windows && any-device-is-level_zero) | |||
| // XFAIL: any-device-is-opencl, any-device-is-cuda, (windows && any-device-is-level_zero), gpu-intel-dg2, hip_amd | |||
| // XFAIL-TRACKER: https://github.com/intel/llvm/issues/15819 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the corresponding GH issue: #15819 with the new failures on DG2 and HIP. It would be helpful to add links to the failing GHA job in the issue as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, done
againull
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I am not mistaken, Udit's concerns were addressed.
This test was failing on post commit in these cases after being re-enabled.
https://github.com/intel/llvm/actions/runs/11523103039