Skip to content

Conversation

@MrSidims
Copy link
Contributor

These decorations doesn't present in
https://github.com/KhronosGroup/SPIRV-LLVM-Translator nor in the spec.

Per ESIMD team these decorations are no longer needed.

Precious PR: #3462

These decorations doesn't present in
https://github.com/KhronosGroup/SPIRV-LLVM-Translator nor in the spec.

Per ESIMD team these decorations are no longer needed.

Precious PR: intel#3462

Signed-off-by: Sidorov, Dmitry <[email protected]>
@MrSidims MrSidims requested a review from a team as a code owner October 27, 2024 20:05
Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlexeySachkov
Copy link
Contributor

Precious PR: #3462

“Curse the Baggins! It’s gone! What has it got in its pocketses? Oh we guess, we guess, my precious. He’s found it, yes he must have.”

@sarnex
Copy link
Contributor

sarnex commented Oct 28, 2024

Discussed with Dmitry offline, this is syclos only code originally so we can't upstream anything, and it's not an ABI break.

@sarnex sarnex merged commit a0b5f56 into intel:sycl Oct 28, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants