Skip to content

Conversation

@Bensuo
Copy link
Contributor

@Bensuo Bensuo commented Oct 29, 2024

  • Update UR tag for fix for updating local accessors on CUDA/HIP
  • Add e2e tests covering local accessor usage

Copy link
Contributor

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, left some minor comments. Main questions is if we need any new spec wording around local memory update?

- Update UR tag for fix to updating local accessors on CUDA/HIP
- Add e2e tests covering local accessor usage
@callumfare
Copy link
Contributor

@Bensuo @EwanC The UR PR has merged now. I've updated the UR tag but could you rebase/merge in the latest sycl branch?

@EwanC
Copy link
Contributor

EwanC commented Nov 6, 2024

@callumfare Should be good now

@EwanC
Copy link
Contributor

EwanC commented Nov 6, 2024

@intel/llvm-gatekeepers This is good to go, thanks

@martygrant martygrant merged commit cda38de into intel:sycl Nov 6, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants