Skip to content

[UR] Add device info query for native assert. #15929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 11, 2025
Merged

[UR] Add device info query for native assert. #15929

merged 11 commits into from
Mar 11, 2025

Conversation

@aarongreig
Copy link
Contributor

@aarongreig aarongreig commented Oct 30, 2024

No description provided.

@aarongreig aarongreig force-pushed the aaron/addAssertDeviceInfoQuery branch from aaca08c to 7a04e8b Compare November 1, 2024 10:55
@aarongreig aarongreig force-pushed the aaron/addAssertDeviceInfoQuery branch from 7a04e8b to cedd602 Compare November 1, 2024 10:58
@aarongreig aarongreig marked this pull request as ready for review November 1, 2024 10:58
@aarongreig aarongreig requested review from a team as code owners November 1, 2024 10:58
@aarongreig aarongreig changed the title [UR] Add device info query for devicelib assert. [UR] Add device info query for native assert. Nov 1, 2024
@aarongreig aarongreig mentioned this pull request Nov 1, 2024
Closed
uditagarwal97
uditagarwal97 reviewed Nov 7, 2024
View reviewed changes
Copy link
Contributor

@uditagarwal97 uditagarwal97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also have a test to validate this change?

@aarongreig
Copy link
Contributor Author

aarongreig commented Nov 8, 2024

can we also have a test to validate this change?

added a unit test to make sure the aspect is being correctly reported

@aarongreig
Merge branch 'sycl' into aaron/addAssertDeviceInfoQuery
3f1274d
@aarongreig
Add device info query to report support for native asserts.
efd29e7 
This allows cuda and hip to stop reporting the relevant opencl extension
string, see issue intel#1374
@aarongreig aarongreig requested review from a team as code owners February 24, 2025 15:27
@aarongreig aarongreig requested a review from Seanst98 February 24, 2025 15:27
@aarongreig
Copy link
Contributor Author

aarongreig commented Feb 24, 2025

UR changes ported from oneapi-src/unified-runtime#2269

@aarongreig
Copy link
Contributor Author

aarongreig commented Mar 11, 2025

@intel/llvm-gatekeepers please merge

@kbenzie kbenzie merged commit c07039e into intel:sycl Mar 11, 2025
31 checks passed
adamfidel pushed a commit to reble/llvm that referenced this pull request Mar 11, 2025
@aarongreig @adamfidel
[UR] Add device info query for native assert. (intel#15929)
a8c8923
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uditagarwal97 uditagarwal97 uditagarwal97 approved these changes

@Seanst98 Seanst98 Awaiting requested review from Seanst98 Seanst98 is a code owner automatically assigned from intel/llvm-reviewers-cuda

+3 more reviewers

@frasercrmck frasercrmck frasercrmck approved these changes

@hvdijk hvdijk hvdijk approved these changes

@kbenzie kbenzie kbenzie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aarongreig @frasercrmck @hvdijk @kbenzie @uditagarwal97