-
Notifications
You must be signed in to change notification settings - Fork 794
[SYCL][E2E] Add functionality to split build and run of e2e tests #16016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 23 commits
7432d1c
be37e41
be6805f
10d2c4c
4eb0d31
0ed6008
dd77b6d
364994d
29048da
b8e6cfc
0f19c31
97369f7
70c2555
1387eed
dfcbcd1
b40fcf3
b8b1b1e
2811890
ef98efd
4bd4857
1f393c0
5fcb771
f3fc08f
f1b98c3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| // using --offload-compress without zstd should throw an error. | ||
| // REQUIRES: !zstd | ||
| // REQUIRES: build-and-run-mode | ||
| // RUN: not %{build} %O0 -g --offload-compress %S/Inputs/single_kernel.cpp -o %t_compress.out 2>&1 | FileCheck %s | ||
| // CHECK: '--offload-compress' option is specified but zstd is not available. The device image will not be compressed. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,7 +11,7 @@ | |
| // RUN: %{build} -o %t.out | ||
| // RUN: %{run} %t.out | ||
|
|
||
| // XFAIL:* | ||
| // XFAIL: run-mode | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. sorry if i asked this before but i wonder if we can implement this inside the python scripts instead of requiring test changes There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These changes are to differentiate between tests that fail when compiling vs tests that fail when running. These tests originally are able to build so marking as There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I want (very strongly) to start with explicit tests markup first before we introduce any heuristics in the lit logic, especially if that's really heuristics and not some bullet-proof correct logic. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i guess im just worried this feature will slow down/confuse developers writing tests, im willing to proceed with this as-is and see what happens, but we should be ready to revert/fix the problem fast if some issue comes up There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
For now since there is no automatic running on CI enabled, we'll just have to monitor the failures manually. However once this is integrated into the post/pre commit I think it should be pretty straightforward to figure out the appropriate action given the ci's behaviour:
|
||
|
|
||
| #include "../common.hpp" | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.