[SYCL] remove invoking kernel_compiler #16035
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
precommit failures due to infra issue |
jopperm
reviewed
Nov 12, 2024
Contributor
There was a problem hiding this comment.
Can we keep this (simpler) test for now, and just change it to use the sycl language?
The new approach doesn't handle the kernel_compiler_sycl.cpp test yet for a couple of unimplemented features (ESIMD, checking warnings, etc.). I believe the test failure there is currently hidden.
Contributor
Author
There was a problem hiding this comment.
I'm demoting this PR back to "draft". That hidden test pass/fail made me not realize that the sycl_jit might not be quite ready yet to replace
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For SYCL language support, the original POC wrote files to disk and invoked the clang compiler directly. This is suboptimal for various reasons. The SYCL_JIT compiler followed and is much faster. It is now supported on Windows as well, so there is no reason to have both.
In this PR we are removing the invoking version of kernel_compiler and making the SYCL_JIT one the default for supporting the
source_language::sycloption.