[Driver][SYCL][NFC] Fix memory sanitizer issue for AOT #16063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using AOT for GPU, we will setup implied options for PVC targets. The strings that are formed need to be added to the vector to be processed later. One of these strings was a StringRef so the pointed to location can go away. Make a copy of the string to satisfy the sanitizer.
mdtoguchi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
hchilama
approved these changes
Nov 13, 2024
mdtoguchi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
@intel/llvm-gatekeepers, this looks ready to merge - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using AOT for GPU, we will setup implied options for PVC targets. The strings that are formed need to be added to the vector to be processed later. One of these strings was a StringRef so the pointed to location can go away. Make a copy of the string to satisfy the sanitizer.