Skip to content

Conversation

@steffenlarsen
Copy link
Contributor

This commit implements the sycl_ext_oneapi_event_mode extension. Of particular focus is the low-power event mode.

This commit implements the sycl_ext_oneapi_event_mode extension. Of
particular focus is the low-power event mode.

Signed-off-by: Larsen, Steffen <[email protected]>
Signed-off-by: Larsen, Steffen <[email protected]>
Copy link
Contributor

@cperkinsintel cperkinsintel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - had one question about testing

Signed-off-by: Larsen, Steffen <[email protected]>
@steffenlarsen
Copy link
Contributor Author

@intel/unified-runtime-reviewers - Friendly ping.

Copy link
Contributor

@kbenzie kbenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UR LGTM

@AlexeySachkov AlexeySachkov merged commit 3b48a46 into intel:sycl Dec 16, 2024
14 checks passed
@sarnex
Copy link
Contributor

sarnex commented Dec 16, 2024

@steffenlarsen Sorry, some werror nonsense in postcommit

https://github.com/intel/llvm/actions/runs/12349085225/job/34459175839

 /__w/llvm/llvm/src/sycl/unittests/Extensions/EventMode.cpp:17:8: error: variable 'Params' set but not used [-Werror=unused-but-set-variable]
   17 |   auto Params =

@AlexeySachkov
Copy link
Contributor

@steffenlarsen Sorry, some werror nonsense in postcommit

https://github.com/intel/llvm/actions/runs/12349085225/job/34459175839

 /__w/llvm/llvm/src/sycl/unittests/Extensions/EventMode.cpp:17:8: error: variable 'Params' set but not used [-Werror=unused-but-set-variable]
   17 |   auto Params =

@sarnex, I will take a look

@sarnex
Copy link
Contributor

sarnex commented Dec 16, 2024

@AlexeySachkov Thanks, if you can't repro (if you even need to), remember we are building with oneAPI now in postcommit.

@AlexeySachkov
Copy link
Contributor

@AlexeySachkov Thanks, if you can't repro (if you even need to), remember we are building with oneAPI now in postcommit.

I think that this one should be reproducible with any compiler, its pretty straightforward. I've published #16380

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants